remove warm reboot from diagnostic target

Initially the diagnostic target was only tied to one type of system
event. This one system event required a warm reboot so it made sense to
just put that directly in this recipe. There are now new use cases for
the diagnostic target that do not want or need a warm reboot.

Remove the warm reboot from the diagnostic target and let other recipes
add it if needed for their use cases.

Tested:
- Verified with all commits in this Topic that the witherspoon system
  has the same service layout as before and the rainier system
  has the new layout (crash used for mpipl)

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I31cf0c9a4149a09d7e3f6a4d6b099fc369a0958c
diff --git a/recipes-phosphor/state/phosphor-state-manager-systemd-links.inc b/recipes-phosphor/state/phosphor-state-manager-systemd-links.inc
index 10e255d..2c01dea 100644
--- a/recipes-phosphor/state/phosphor-state-manager-systemd-links.inc
+++ b/recipes-phosphor/state/phosphor-state-manager-systemd-links.inc
@@ -83,11 +83,6 @@
     TARGET="../obmc-host-force-warm-reboot@.target"
     ln -s $TARGET $LINK
 
-    mkdir -p $D$systemd_system_unitdir/obmc-host-diagnostic-mode@0.target.requires
-    LINK="$D$systemd_system_unitdir/obmc-host-diagnostic-mode@0.target.requires/obmc-host-force-warm-reboot@0.target"
-    TARGET="../obmc-host-force-warm-reboot@.target"
-    ln -s $TARGET $LINK
-
     mkdir -p $D$systemd_system_unitdir/obmc-chassis-poweroff@0.target.wants
     LINK="$D$systemd_system_unitdir/obmc-chassis-poweroff@0.target.wants/phosphor-clear-one-time@0.service"
     TARGET="../phosphor-clear-one-time@.service"
@@ -150,9 +145,6 @@
     LINK="$D$systemd_system_unitdir/obmc-host-warm-reboot@0.target.requires/obmc-host-force-warm-reboot@0.target"
     rm $LINK
 
-    LINK="$D$systemd_system_unitdir/obmc-host-diagnostic-mode@0.target.requires/obmc-host-force-warm-reboot@0.target"
-    rm $LINK
-
     LINK="$D$systemd_system_unitdir/obmc-chassis-poweroff@0.target.wants/phosphor-clear-one-time@0.service"
     rm $LINK
 }