phosphor-debug-collector: Create /var/lib/systemd/coredump mount point
Mount /var/lib/systemd/coredump as a tmpfs to be used as a file
location for systemd-coredump generated core dumps.
Proposed fix is a workarround for core file missing in the BMC dump.
Core manager watches for inotify event IN_CLOSE_WRITE on core file to
initiate application core type BMC dump. ubfi based core path triggers
incorrect inotify events, which eventually fails to collect actual
core file.
Resolves openbmc/openbmc#2240
Change-Id: Ia70ea7ea34a05596e5609efca880887884a78387
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
diff --git a/common/recipes-phosphor/dump/phosphor-debug-collector.bb b/common/recipes-phosphor/dump/phosphor-debug-collector.bb
index f6c098e..7be45ec 100644
--- a/common/recipes-phosphor/dump/phosphor-debug-collector.bb
+++ b/common/recipes-phosphor/dump/phosphor-debug-collector.bb
@@ -64,7 +64,10 @@
FILES_${PN}-dreport += "${bindir}/dreport"
DBUS_SERVICE_${PN}-manager += "${MGR_SVC}"
-SYSTEMD_SERVICE_${PN}-monitor += "obmc-dump-monitor.service"
+SYSTEMD_SERVICE_${PN}-monitor += " \
+ obmc-dump-monitor.service \
+ var-lib-systemd-coredump.mount \
+"
EXTRA_OECONF = "BMC_DUMP_PATH=${bmc_dump_path}"
diff --git a/common/recipes-phosphor/dump/phosphor-debug-collector/obmc-dump-monitor.service b/common/recipes-phosphor/dump/phosphor-debug-collector/obmc-dump-monitor.service
index 0e8ef3b..0af6cea 100644
--- a/common/recipes-phosphor/dump/phosphor-debug-collector/obmc-dump-monitor.service
+++ b/common/recipes-phosphor/dump/phosphor-debug-collector/obmc-dump-monitor.service
@@ -1,5 +1,7 @@
[Unit]
Description=Phosphor Dump core monitor.
+Wants=var-lib-systemd-coredump.mount
+Before=var-lib-systemd-coredump.mount
[Service]
ExecStart=/usr/bin/env phosphor-dump-monitor
diff --git a/common/recipes-phosphor/dump/phosphor-debug-collector/var-lib-systemd-coredump.mount b/common/recipes-phosphor/dump/phosphor-debug-collector/var-lib-systemd-coredump.mount
new file mode 100644
index 0000000..66d0e4f
--- /dev/null
+++ b/common/recipes-phosphor/dump/phosphor-debug-collector/var-lib-systemd-coredump.mount
@@ -0,0 +1,7 @@
+[Unit]
+Description=/var/lib/systemd/coredump
+
+[Mount]
+What=tmpfs
+Where=/var/lib/systemd/coredump
+Type=tmpfs