image_types_phosphor: Remove mtd from make_tar_of_images()

The make_tar_of_images() function was adding an mtd suffix to the
tarball name. Make the caller pass the suffix instead so that this
function can be used to create tarballs intended for non-mtd systems
such as systems based on a mmc chip.

Change-Id: If167917f49b9188259ae8fd107af548ee9af6e3a
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
diff --git a/classes/image_types_phosphor.bbclass b/classes/image_types_phosphor.bbclass
index d5ace16..3d919df 100644
--- a/classes/image_types_phosphor.bbclass
+++ b/classes/image_types_phosphor.bbclass
@@ -314,11 +314,11 @@
 	extra_files="$@"
 
 	# Create the tar archive
-	tar -h -cvf ${IMGDEPLOYDIR}/${IMAGE_NAME}.$type.mtd.tar \
+	tar -h -cvf ${IMGDEPLOYDIR}/${IMAGE_NAME}.$type.tar \
 		image-u-boot image-kernel image-rofs image-rwfs $extra_files
 
 	cd ${IMGDEPLOYDIR}
-	ln -sf ${IMAGE_NAME}.$type.mtd.tar ${IMGDEPLOYDIR}/${IMAGE_LINK_NAME}.$type.mtd.tar
+	ln -sf ${IMAGE_NAME}.$type.tar ${IMGDEPLOYDIR}/${IMAGE_LINK_NAME}.$type.tar
 }
 
 do_generate_static_tar() {
@@ -326,7 +326,7 @@
 	ln -sf ${S}/publickey publickey
 	make_image_links ${OVERLAY_BASETYPE} ${IMAGE_BASETYPE}
 	make_signatures image-u-boot image-kernel image-rofs image-rwfs MANIFEST publickey
-	make_tar_of_images static MANIFEST publickey ${signature_files}
+	make_tar_of_images static.mtd MANIFEST publickey ${signature_files}
 
 	# Maintain non-standard legacy link.
 	cd ${IMGDEPLOYDIR}
@@ -348,7 +348,7 @@
 	ln -sf ${S}/publickey publickey
 	make_image_links ${FLASH_UBI_OVERLAY_BASETYPE} ${FLASH_UBI_BASETYPE}
 	make_signatures image-u-boot image-kernel image-rofs image-rwfs MANIFEST publickey
-	make_tar_of_images ubi MANIFEST publickey ${signature_files}
+	make_tar_of_images ubi.mtd MANIFEST publickey ${signature_files}
 }
 do_generate_ubi_tar[dirs] = " ${S}/ubi"
 do_generate_ubi_tar[depends] += " \