tree eaef769723108c6b7dc20f8e20a82232e39a2a0d
parent 0519a400871715cd42b44ec75a9e6bb6149c993a
author Andrew Jeffery <andrew@aj.id.au> 1486348257 +1030
committer Patrick Williams <patrick@stwcx.xyz> 1486661533 +0000

mboxd: Use escaped unit names for device dependencies

Inspecting the journal showed that the device units that mboxd depends
on were timing out:

    Jan 30 02:48:29 witherspoon systemd[1]: Timed out waiting for device dev-aspeed-lpc-ctrl.device.
    Jan 30 02:48:29 witherspoon systemd[1]: dev-aspeed-lpc-ctrl.device: Job dev-aspeed-lpc-ctrl.device/start failed with result 'timeout'.
    Jan 30 02:48:29 witherspoon systemd[1]: dev-aspeed-mbox.device: Job dev-aspeed-mbox.device/start timed out.
    Jan 30 02:48:29 witherspoon systemd[1]: Timed out waiting for device dev-aspeed-mbox.device.
    Jan 30 02:48:29 witherspoon systemd[1]: dev-aspeed-mbox.device: Job dev-aspeed-mbox.device/start failed with result 'timeout'

As it turns out, systemd wants escaped strings to cope with e.g. paths
with dashes in the filename. Update the Wants/After lines to use the
escaped strings. The escaped values were created running
`systemd-escape`[1] on a Zaius image under QEMU:

    root@zaius:~# systemd-escape -p /dev/aspeed-*
    dev-aspeed\x2dlpc\x2dctrl dev-aspeed\x2dmbox

This leaves us with the happy result of no timeouts:

    # journalctl | grep aspeed
    ...
    Feb 06 02:25:22 zaius systemd[1]: Found device /dev/aspeed-mbox.
    Feb 06 02:25:25 zaius systemd[1]: Found device /dev/aspeed-lpc-ctrl.
    ...

[1] https://www.freedesktop.org/software/systemd/man/systemd-escape.html#

Change-Id: I4770026842757768b20b919125af47ae499d1667
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>