tree 5a4c4fa5ca4a8882c42cb680ebdfd21be5e9ba3a
parent 9b40f49d7373c596758bf3a2a9c6988838f5fc87
author Andrew Geissler <geissonator@yahoo.com> 1547830848 -0600
committer Brad Bishop <bradleyb@fuzziesquirrel.com> 1550094134 +0000

Ensure ipmid doesn't start until on dbus

Other services rely on phosphor-ipmi-host providing needed dbus
interfaces once its been started. Due to other services providing
identical dbus object paths, the normal mapper wait services are not an
option here.

Ensure systemd does not consider this service active until it has
registered the host control dbus object.

I'm working on a long term fix to this in
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-objmgr/+/17990/
(a refactor with unit tests) and
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-objmgr/+/17837/
(close race condition due to introspection) but I think this change here
makes things better overall so I'd like to get it merged

Testing:
Verified systemd now waits for ipmid to really get up and running and
ran through HW CI

Jan 18 19:56:00 witherspoon systemd[1]: Starting Phosphor Inband IPMI...
Jan 18 19:56:03 witherspoon ipmid[1336]: JSON file not found
Jan 18 19:56:09 witherspoon systemd[1]: Started Phosphor Inband IPMI.

I had our internal test team try out this patch on a Romulus. They were
seeing this issue this is trying to fix on a very regular basis. With
this change, they completed 265 successful boot tests. The ipmid process
does host 2 well-know names, openbmc_project.Ipmi.Host and
xyz.openbmc_project.Control.Host. I verified via a bus capture that
xyz.openbmc_project.Control.Host is the last one to be put on the bus.

Resolves openbmc/phosphor-state-manager#2

Change-Id: I363758793bdad1fc14560e50a9b77f1906da456f
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>