| commit | 079fc516efb9e0017b9ae66d558f2cdb423caaa6 | [log] [tgz] |
|---|---|---|
| author | Andrew Jeffery <andrew@codeconstruct.com.au> | Tue Jul 09 16:51:56 2024 +0930 |
| committer | Andrew Jeffery <andrew@codeconstruct.com.au> | Tue Jul 09 16:53:06 2024 +0930 |
| tree | 7001e2f86a1fada10ad27a1dde0ca917367e47d7 | |
| parent | e2826c7def432a5c8f694ffb87355cb80862612b [diff] |
console-server: Fix printf() format string for discovered handlers
GCC reports the following on ARM:
```
../../../../../../workspace/sources/obmc-console/console-server.c: In function 'handlers_init':
../../../../../../workspace/sources/obmc-console/console-server.c:549:19: error: format '%ld' expects argument of type 'long int', but argument 2 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
549 | printf("%ld handler type%s\n", n_types, n_types == 1 ? "" : "s");
| ~~^ ~~~~~~~
| | |
| long int size_t {aka unsigned int}
| %d
```
Change-Id: Ib40f2e0576588d8dbd6fd38c4e969a1749c18538
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
To build this project, run the following shell commands:
meson setup build meson compile -C build
To test:
meson test -C build
Running the server requires a serial port (e.g. /dev/ttyS0):
touch obmc-console.conf ./obmc-console-server --config obmc-console.conf ttyS0
To connect to the server, simply run the client:
./obmc-console-client
To disconnect the client, use the standard ~. combination.
This shows how the host UART connection is abstracted within the BMC as a Unix domain socket.
+---------------------------------------------------------------------------------------------+
| |
| obmc-console-client unix domain socket obmc-console-server |
| |
| +----------------------+ +------------------------+ |
| | client.2200.conf | +---------------------+ | server.ttyVUART0.conf | |
+---+--+ +----------------------+ | | +------------------------+ +--------+-------+
Network | 2200 +--> +->+ @obmc-console.host0 +<-+ <--+ /dev/ttyVUART0 | UARTs
+---+--+ | console-id = "host0" | | | | console-id = "host0" | +--------+-------+
| | | +---------------------+ | | |
| +----------------------+ +------------------------+ |
| |
| |
| |
+---------------------------------------------------------------------------------------------+
This supports multiple independent consoles. The console-id is a unique portion for the unix domain socket created by the obmc-console-server instance. The server needs to know this because it needs to know what to name the pipe; the client needs to know it as it needs to form the abstract socket name to which to connect.