Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / obmc-console / 15792aa711c573c5f2c252b7c7eb7e7fa523909d
commit15792aa711c573c5f2c252b7c7eb7e7fa523909d[log] [tgz]
authorAndrew Jeffery <andrew@aj.id.au>Tue Apr 18 16:47:33 2023 +0930
committerAndrew Jeffery <andrew@aj.id.au>Thu Apr 20 13:21:34 2023 +0930
treea8e21361d1faf7e93f240e12b2623618f24f8fe2
parentd0a85567791e6c9349883834908a5bdf4a8ae49b [diff]
console-server: tty_find_device(): Assign rc on error

Avoid invoking open(2) with console->tty_dev as NULL:

```
[12/34] Compiling C object obmc-console-server.p/console-server.c.o
../../../console-server.c:263:20: warning: Null pointer passed to 1st parameter expecting 'nonnull' [core.NonNullParamChecker]
        console->tty_fd = open(console->tty_dev, O_RDWR);
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Iafb2e6ac790f66f71d591a68d1b918117074fd77
1 file changed
tree: a8e21361d1faf7e93f240e12b2623618f24f8fe2
  1. conf/
  2. test/
  3. .gitignore
  4. .travis.yml
  5. bootstrap.sh
  6. config.c
  7. configure.ac
  8. console-client.c
  9. console-server.c
  10. console-server.h
  11. console-socket.c
  12. LICENSE
  13. log-handler.c
  14. Makefile.am
  15. meson.build
  16. meson_options.txt
  17. OWNERS
  18. README.md
  19. ringbuffer.c
  20. socket-handler.c
  21. tty-handler.c
  22. util.c
README.md

To Build

Note: In addition to a toolchain and autoconf tools, this requires autotools-archive to be installed.

To build this project, run the following shell commands:

./bootstrap.sh
./configure ${CONFIGURE_FLAGS}
make

To fully clean the repository, run:

./bootstrap.sh clean

To Run Server

Running the server requires a serial port (e.g. /dev/ttyS0):

touch obmc-console.conf
./obmc-console-server --config obmc-console.conf ttyS0

To Connect Client

To connect to the server, simply run the client:

./obmc-console-client

To disconnect the client, use the standard ~. combination.

Underlying design

This shows how the host UART connection is abstracted within the BMC as a Unix domain socket.

               +--------------------------------------------------------------------------------------------+
               |                                                                                            |
               |       obmc-console-client      unix domain socket         obmc-console-server              |
               |                                                                                            |
               |     +---------------------+                           +------------------------+           |
               |     | client.2200.conf    |  +---------------------+  | server.ttyVUART0.conf  |           |
           +---+--+  +---------------------+  |                     |  +------------------------+  +--------+-------+
Network    | 2200 +-->                     +->+ @obmc-console.host0 +<-+                        <--+ /dev/ttyVUART0 |   UARTs
           +---+--+  | socket-id = "host0" |  |                     |  | socket-id = "host0"    |  +--------+-------+
               |     |                     |  +---------------------+  |                        |           |
               |     +---------------------+                           +------------------------+           |
               |                                                                                            |
               |                                                                                            |
               |                                                                                            |
               +--------------------------------------------------------------------------------------------+

This supports multiple independent consoles. The socket-id is a unique portion for the unix domain socket created by the obmc-console-server instance. The server needs to know this because it needs to know what to name the pipe; the client needs to know it as it needs to form the abstract socket name to which to connect.