tree d4922e8ef1ca5f8754a0d8fea96a17e5497084a0
parent 498a4a81d93b0242cea5de929f00cade2b5fe9f2
author Alexander Hansen <alexander.hansen@9elements.com> 1718202958 +0200
committer Alexander Hansen <alexander.hansen@9elements.com> 1720528780 +0200

use iniparser dependency for config file parsing

For the config file, we do not need the custom handwritten parser.

Thanks to Andrew for this command, we can now search for an alternative

$ git grep -lw INI -- :/:*.bb
meta-openembedded/meta-oe/recipes-support/inih/libinih_58.bb
meta-openembedded/meta-oe/recipes-support/iniparser/iniparser_4.1.bb
meta-openembedded/meta-oe/recipes-support/minini/minini_1.2.b.bb
poky/meta/recipes-devtools/python/python3-iniconfig_2.0.0.bb
poky/meta/recipes-devtools/python/python3-iniparse_0.5.bb

For the ini parser we have following requirements

- small API
- easy to use
- compiles fast
- has tests, examples, docs
- support for sections

- minini [1]

  can be dropped from the list since it also supports colon
  ':' instead of '=' for separating key and value, creating 2 ways of
  doing something. This makes it harder to swap out the ini parser in
  the future.

- libinih [2]

  uses SAX-style parsing of .ini files and thus does not provide
  a DOM of the .ini. This is a break from the previous parser which
  stored everything in struct config. To use this library would require
  to create a struct to store all the possible configuration, then fill
  that struct in one pass. Essentially wrapping that library to have
  DOM capability. That would be possible, but not ideal. libinih is also
  highly configurable with lots of config options.

- iniparser [3]

  has all the required features and stores the results of its
  parsing for later use. It is a seamless upgrade from the previous
  parser. The call sites do not have to be modified and we can read the
  config as before. A downside is that we have to provide our own wrap
  file.

For our purposes, iniparser is a good choice.

Using this dependency allows us to drop the custom parser and all the
tests that go along with it.

If sections are required in future config files, iniparser can also
support that.

References:

[1] https://github.com/compuphase/minIni
[2] https://github.com/benhoyt/inih
[3] https://gitlab.com/iniparser/iniparser

Change-Id: Ie2b57171ec1f8cb6b1b80ca1d9e6c112bedc1195
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>