Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / obmc-console / 6925740d318e6c305463f3d430d2064da6102752
commit6925740d318e6c305463f3d430d2064da6102752[log] [tgz]
authorAlexander Hansen <alexander.hansen@9elements.com>Fri Jun 07 15:17:09 2024 +0200
committerAlexander Hansen <alexander.hansen@9elements.com>Thu Jun 27 17:17:58 2024 +0200
tree30e8250f39a155f2f2cb6109242a9d555805d8ef
parent46d9ef298f2e26f4c513fedff3b8a26fdf4b2d35 [diff]
Refactor run_console: extract function

run_console has a loop that contains a lot of code and causes
unnecessary indentation. This can be extracted into a separate function,
which makes it more readable.

replace 'break' -> 'return -1'
replace 'continue' -> 'return 0'

Based on the return value of run_console_iteration, the loop can break
or continue as before.

The behavior should be the same.

Change-Id: I46337c49a559d326206ab7e7cce9c6a83f2550b9
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
1 file changed
tree: 30e8250f39a155f2f2cb6109242a9d555805d8ef
  1. conf/
  2. test/
  3. .clang-format
  4. .clang-tidy
  5. .gitignore
  6. .travis.yml
  7. CHANGELOG.md
  8. config.c
  9. console-client.c
  10. console-dbus.c
  11. console-server.c
  12. console-server.h
  13. console-socket.c
  14. LICENSE
  15. log-handler.c
  16. meson.build
  17. meson.options
  18. OWNERS
  19. README.md
  20. ringbuffer.c
  21. socket-handler.c
  22. tty-handler.c
  23. util.c
README.md

To Build

To build this project, run the following shell commands:

meson setup build
meson compile -C build

To test:

meson test -C build

To Run Server

Running the server requires a serial port (e.g. /dev/ttyS0):

touch obmc-console.conf
./obmc-console-server --config obmc-console.conf ttyS0

To Connect Client

To connect to the server, simply run the client:

./obmc-console-client

To disconnect the client, use the standard ~. combination.

Underlying design

This shows how the host UART connection is abstracted within the BMC as a Unix domain socket.

               +---------------------------------------------------------------------------------------------+
               |                                                                                             |
               |       obmc-console-client       unix domain socket         obmc-console-server              |
               |                                                                                             |
               |     +----------------------+                           +------------------------+           |
               |     |   client.2200.conf   |  +---------------------+  | server.ttyVUART0.conf  |           |
           +---+--+  +----------------------+  |                     |  +------------------------+  +--------+-------+
Network    | 2200 +-->                      +->+ @obmc-console.host0 +<-+                        <--+ /dev/ttyVUART0 |   UARTs
           +---+--+  | console-id = "host0" |  |                     |  |  console-id = "host0"  |  +--------+-------+
               |     |                      |  +---------------------+  |                        |           |
               |     +----------------------+                           +------------------------+           |
               |                                                                                             |
               |                                                                                             |
               |                                                                                             |
               +---------------------------------------------------------------------------------------------+

This supports multiple independent consoles. The console-id is a unique portion for the unix domain socket created by the obmc-console-server instance. The server needs to know this because it needs to know what to name the pipe; the client needs to know it as it needs to form the abstract socket name to which to connect.