| commit | c7a8f001a6ef9464c27af608b3e443a6dc40ebaa | [log] [tgz] |
|---|---|---|
| author | Andrew Jeffery <andrew@aj.id.au> | Tue Apr 18 12:08:20 2023 +0930 |
| committer | Andrew Jeffery <andrew@aj.id.au> | Wed Apr 19 08:19:26 2023 +0930 |
| tree | f14d782845b6d766d691306d2b17c4ac8776a35c | |
| parent | fd04832808ed77b900d76dc1c9e9fe9b691e2fbd [diff] |
console-server: Drop trailing semi-colon from console_handler_register()
It's idiomatic for the semi-colon to appear on the call-site.
```
cc -Iobmc-console-server.p -I. -I.. -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -Werror -std=gnu17 -O2 -g '-DLOCALSTATEDIR="/var/local"' '-DSYSCONFDIR="etc"' -MD -MQ obmc-console-server.p/log-handler.c.o -MF obmc-console-server.p/log-handler.c.o.d -o obmc-console-server.p/log-handler.c.o -c ../log-handler.c
../log-handler.c:190:47: error: ISO C does not allow extra ‘;’ outside of a function [-Werror=pedantic]
190 | console_handler_register(&log_handler.handler);
| ^
cc1: all warnings being treated as errors
```
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib6e445cf5cab2e4ce6f5ddd822e3afb4a76288b4
Note: In addition to a toolchain and autoconf tools, this requires autotools-archive to be installed.
To build this project, run the following shell commands:
./bootstrap.sh
./configure ${CONFIGURE_FLAGS}
make
To fully clean the repository, run:
./bootstrap.sh clean
Running the server requires a serial port (e.g. /dev/ttyS0):
touch obmc-console.conf ./obmc-console-server --config obmc-console.conf ttyS0
To connect to the server, simply run the client:
./obmc-console-client
To disconnect the client, use the standard ~. combination.
This shows how the host UART connection is abstracted within the BMC as a Unix domain socket.
+--------------------------------------------------------------------------------------------+
| |
| obmc-console-client unix domain socket obmc-console-server |
| |
| +---------------------+ +------------------------+ |
| | client.2200.conf | +---------------------+ | server.ttyVUART0.conf | |
+---+--+ +---------------------+ | | +------------------------+ +--------+-------+
Network | 2200 +--> +->+ @obmc-console.host0 +<-+ <--+ /dev/ttyVUART0 | UARTs
+---+--+ | socket-id = "host0" | | | | socket-id = "host0" | +--------+-------+
| | | +---------------------+ | | |
| +---------------------+ +------------------------+ |
| |
| |
| |
+--------------------------------------------------------------------------------------------+
This supports multiple independent consoles. The socket-id is a unique portion for the unix domain socket created by the obmc-console-server instance. The server needs to know this because it needs to know what to name the pipe; the client needs to know it as it needs to form the abstract socket name to which to connect.