Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / obmc-console / 48d1f533efab4d48d45de5a79ed86f9b6814d068
commit48d1f533efab4d48d45de5a79ed86f9b6814d068[log] [tgz]
authorAndrew Jeffery <andrew@codeconstruct.com.au>Tue Jul 09 14:46:14 2024 +0930
committerAndrew Jeffery <andrew@codeconstruct.com.au>Tue Jul 09 17:57:17 2024 +0930
treee313f369774f8a105a63bfbbbd95e5ae90cf552e
parent3f8d5bebebd401ab99e255dd648b55290bd1495a [diff]
log-hander: Fix leak of rotate_filename in cleanup path

Running `obmc-console-server` under valgrind yields:

```
==259265== 34 bytes in 1 blocks are definitely lost in loss record 1 of 1
==259265==    at 0x48407B4: malloc (vg_replace_malloc.c:381)
==259265==    by 0x49BC427: __vasprintf_internal (vasprintf.c:71)
==259265==    by 0x498FBD5: asprintf (asprintf.c:31)
==259265==    by 0x10F2EF: log_init (log-handler.c:189)
==259265==    by 0x10EBEB: handlers_init (console-server.c:564)
==259265==    by 0x10EBEB: main (console-server.c:1000)
```

Free rotate_filename to avoid the leak.

Change-Id: Ib403d50d47b5d266bab415944cbae93582ecdb65
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
1 file changed
tree: e313f369774f8a105a63bfbbbd95e5ae90cf552e
  1. conf/
  2. test/
  3. .clang-format
  4. .clang-tidy
  5. .gitignore
  6. .travis.yml
  7. CHANGELOG.md
  8. config.c
  9. console-client.c
  10. console-dbus.c
  11. console-server.c
  12. console-server.h
  13. console-socket.c
  14. LICENSE
  15. log-handler.c
  16. meson.build
  17. meson.options
  18. OWNERS
  19. README.md
  20. ringbuffer.c
  21. socket-handler.c
  22. tty-handler.c
  23. util.c
README.md

To Build

To build this project, run the following shell commands:

meson setup build
meson compile -C build

To test:

meson test -C build

To Run Server

Running the server requires a serial port (e.g. /dev/ttyS0):

touch obmc-console.conf
./obmc-console-server --config obmc-console.conf ttyS0

To Connect Client

To connect to the server, simply run the client:

./obmc-console-client

To disconnect the client, use the standard ~. combination.

Underlying design

This shows how the host UART connection is abstracted within the BMC as a Unix domain socket.

               +---------------------------------------------------------------------------------------------+
               |                                                                                             |
               |       obmc-console-client       unix domain socket         obmc-console-server              |
               |                                                                                             |
               |     +----------------------+                           +------------------------+           |
               |     |   client.2200.conf   |  +---------------------+  | server.ttyVUART0.conf  |           |
           +---+--+  +----------------------+  |                     |  +------------------------+  +--------+-------+
Network    | 2200 +-->                      +->+ @obmc-console.host0 +<-+                        <--+ /dev/ttyVUART0 |   UARTs
           +---+--+  | console-id = "host0" |  |                     |  |  console-id = "host0"  |  +--------+-------+
               |     |                      |  +---------------------+  |                        |           |
               |     +----------------------+                           +------------------------+           |
               |                                                                                             |
               |                                                                                             |
               |                                                                                             |
               +---------------------------------------------------------------------------------------------+

This supports multiple independent consoles. The console-id is a unique portion for the unix domain socket created by the obmc-console-server instance. The server needs to know this because it needs to know what to name the pipe; the client needs to know it as it needs to form the abstract socket name to which to connect.