Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / obmc-console / ab64dadd9506d6f93ff98b9e1d51d12a9df76523
commitab64dadd9506d6f93ff98b9e1d51d12a9df76523[log] [tgz]
authorAndrew Jeffery <andrew@codeconstruct.com.au>Wed Jul 10 09:12:34 2024 +0930
committerAndrew Jeffery <andrew@codeconstruct.com.au>Wed Jul 10 09:12:34 2024 +0930
tree9d926773afba9e3fa01ebe7014b30ee209d646a3
parent1e04f449b7f00a7b426615533a44519149d2ea38 [diff]
subprojects: iniparser: Address meson run_command() warning

The `run_command()` invocations in the iniparser meson.build lacked the
`check` parameter:

```
iniparser| WARNING: You should add the boolean check kwarg to the run_command call.
iniparser| It currently defaults to false,
iniparser| but it will default to true in future releases of meson.
iniparser| See also: https://github.com/mesonbuild/meson/issues/9300
```

Add `check` and set it to true to make sure the build configuration only
succeeds if these commands also succeed.

Fixes: 1e04f449b7f0 ("use iniparser dependency for config file parsing")
Change-Id: I97841398fc899e876b97e4e28e18cd8dd3b13222
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
1 file changed
tree: 9d926773afba9e3fa01ebe7014b30ee209d646a3
  1. conf/
  2. subprojects/
  3. test/
  4. .clang-format
  5. .clang-tidy
  6. .gitignore
  7. .travis.yml
  8. CHANGELOG.md
  9. config-internal.h
  10. config.c
  11. config.h
  12. console-client.c
  13. console-dbus.c
  14. console-server.c
  15. console-server.h
  16. console-socket.c
  17. LICENSE
  18. log-handler.c
  19. meson.build
  20. meson.options
  21. OWNERS
  22. README.md
  23. ringbuffer.c
  24. socket-handler.c
  25. tty-handler.c
  26. util.c
README.md

To Build

To build this project, run the following shell commands:

meson setup build
meson compile -C build

To test:

meson test -C build

To Run Server

Running the server requires a serial port (e.g. /dev/ttyS0):

touch obmc-console.conf
./obmc-console-server --config obmc-console.conf ttyS0

To Connect Client

To connect to the server, simply run the client:

./obmc-console-client

To disconnect the client, use the standard ~. combination.

Underlying design

This shows how the host UART connection is abstracted within the BMC as a Unix domain socket.

               +---------------------------------------------------------------------------------------------+
               |                                                                                             |
               |       obmc-console-client       unix domain socket         obmc-console-server              |
               |                                                                                             |
               |     +----------------------+                           +------------------------+           |
               |     |   client.2200.conf   |  +---------------------+  | server.ttyVUART0.conf  |           |
           +---+--+  +----------------------+  |                     |  +------------------------+  +--------+-------+
Network    | 2200 +-->                      +->+ @obmc-console.host0 +<-+                        <--+ /dev/ttyVUART0 |   UARTs
           +---+--+  | console-id = "host0" |  |                     |  |  console-id = "host0"  |  +--------+-------+
               |     |                      |  +---------------------+  |                        |           |
               |     +----------------------+                           +------------------------+           |
               |                                                                                             |
               |                                                                                             |
               |                                                                                             |
               +---------------------------------------------------------------------------------------------+

This supports multiple independent consoles. The console-id is a unique portion for the unix domain socket created by the obmc-console-server instance. The server needs to know this because it needs to know what to name the pipe; the client needs to know it as it needs to form the abstract socket name to which to connect.