ssh-console: introduce reasonable timeout values
The obmc-console design is that it must successfully send its data to
all connected clients before it will process any new data. This
guarantees there are no data losses to clients.
The drawback to this design is that if a single client stops responding
or gets hung up in some way, all clients get hung up. At IBM, our test
teams utilize some fairly extensive perl/expect based test suites that
utilize the host virtual console extensively. We continue to see
intermittent issues when running these test suites where the virtual
console to our hypervisor becomes unusable. If we log in and start to
kill dropbear ssh console sessions, we eventually find the right one and
the console starts working again.
This commit introduces some parameters to dropbear to drop the bad
client connection if it becomes unresponsive:
-I <idle_timeout>
-K <keepalive>
For idle_timeout, it seems reasonable to give the client 30 minutes
(1800 seconds) of inactivity.
For keepalive, it seems reasonable to assume that a client connection
can be verified within 10 seconds.
Tested:
- The issue is somewhat difficult to recreate but we did patch a system
which was having this issue and we were unable to recreate the problem
with this change. The test suite appears to recover if it senses it
has a dropped connection.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Iaa1182d52fb75762c47e515e43f1fc6352b5bdd1
diff --git a/conf/obmc-console-ssh@.service.in b/conf/obmc-console-ssh@.service.in
index 10e106b..7314756 100644
--- a/conf/obmc-console-ssh@.service.in
+++ b/conf/obmc-console-ssh@.service.in
@@ -8,7 +8,7 @@
Environment="DROPBEAR_RSAKEY_DIR=/etc/dropbear"
EnvironmentFile=/etc/default/dropbear
EnvironmentFile=-/etc/default/obmc-console-client
-ExecStart=/usr/sbin/dropbear -r ${DROPBEAR_RSAKEY_DIR}/dropbear_rsa_host_key -c "/usr/bin/obmc-console-client -c /etc/obmc-console/client.%i.conf" -p %i -F $DROPBEAR_EXTRA_ARGS
+ExecStart=/usr/sbin/dropbear -I 1800 -K 10 -r ${DROPBEAR_RSAKEY_DIR}/dropbear_rsa_host_key -c "/usr/bin/obmc-console-client -c /etc/obmc-console/client.%i.conf" -p %i -F $DROPBEAR_EXTRA_ARGS
SyslogIdentifier=console-client-%i
ExecReload=/bin/kill -HUP $MAINPID
KillMode=process