| commit | 15ceb3e39ac0d8b1682186c8f21984cc1f12ff79 | [log] [tgz] |
|---|---|---|
| author | Andrew Jeffery <andrew@aj.id.au> | Tue Apr 18 11:52:36 2023 +0930 |
| committer | Andrew Jeffery <andrew@aj.id.au> | Tue Apr 18 13:19:30 2023 +0930 |
| tree | 850ec8b060bd5635ce665a818cc9316c4e2838fa | |
| parent | cc07530fdb356b7750f58c2a6b35c9cf180ed99c [diff] |
ringbuffer: Implement min() as an inline function
```
cc -Iobmc-console-server.p -I. -I.. -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -Werror -std=gnu17 -O2 -g '-DLOCALSTATEDIR="/var/local"' '-DSYSCONFDIR="etc"' -MD -MQ obmc-console-server.p/ringbuffer.c.o -MF obmc-console-server.p/ringbuffer.c.o.d -o obmc-console-server.p/ringbuffer.c.o -c ../ringbuffer.c
../ringbuffer.c: In function ‘ringbuffer_queue’:
../ringbuffer.c:26:18: error: ISO C forbids braced-groups within expressions [-Werror=pedantic]
26 | #define min(a,b) ({ \
| ^
../ringbuffer.c:173:16: note: in expansion of macro ‘min’
173 | wlen = min(len, rb->size - rb->tail);
| ^~~
cc1: all warnings being treated as errors
```
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I17f117fb0b6dc7941b119e435a37f3c862296754
Note: In addition to a toolchain and autoconf tools, this requires autotools-archive to be installed.
To build this project, run the following shell commands:
./bootstrap.sh
./configure ${CONFIGURE_FLAGS}
make
To fully clean the repository, run:
./bootstrap.sh clean
Running the server requires a serial port (e.g. /dev/ttyS0):
touch obmc-console.conf ./obmc-console-server --config obmc-console.conf ttyS0
To connect to the server, simply run the client:
./obmc-console-client
To disconnect the client, use the standard ~. combination.
This shows how the host UART connection is abstracted within the BMC as a Unix domain socket.
+--------------------------------------------------------------------------------------------+
| |
| obmc-console-client unix domain socket obmc-console-server |
| |
| +---------------------+ +------------------------+ |
| | client.2200.conf | +---------------------+ | server.ttyVUART0.conf | |
+---+--+ +---------------------+ | | +------------------------+ +--------+-------+
Network | 2200 +--> +->+ @obmc-console.host0 +<-+ <--+ /dev/ttyVUART0 | UARTs
+---+--+ | socket-id = "host0" | | | | socket-id = "host0" | +--------+-------+
| | | +---------------------+ | | |
| +---------------------+ +------------------------+ |
| |
| |
| |
+--------------------------------------------------------------------------------------------+
This supports multiple independent consoles. The socket-id is a unique portion for the unix domain socket created by the obmc-console-server instance. The server needs to know this because it needs to know what to name the pipe; the client needs to know it as it needs to form the abstract socket name to which to connect.