commit 0049bfac6f538c89b75d23c42d094a883c55b881
author Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> Wed Mar 06 15:39:58 2019 -0800
committer Edward A. James <eajames@us.ibm.com> Thu Mar 21 19:19:12 2019 +0000
tree e36092df13d7bd263ead50c8c78c54ffa0e3c5c5
parent 06ad085f07765e282aed8a97931c95075cb8e383

Fix video restarting sync issue

There is a video start/stop sync issue inbetween ikvm server and
ikvm manager because newClient and clientGone callbacks are called
by a different thread from libvncserver. To fix this issue, this
commit moves the video.start() call from server to manager to
unify video control thread.

Tested:
  Open KVM web page and reload the web page by pressing F5.
  KVM page should be reloaded correctly.

Change-Id: Ic0d14ea712510318e9e8f45615a95e82aeaaddf1
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

ikvm_manager.cpp

diff --git a/ikvm_manager.cpp b/ikvm_manager.cpp
index 5e014d0..d56110d 100644
--- a/ikvm_manager.cpp
+++ b/ikvm_manager.cpp
@@ -21,6 +21,7 @@
     {
         if (server.wantsFrame())
         {
+            video.start();
             video.getFrame();
             server.sendFrame();
         }

ikvm_server.cpp

diff --git a/ikvm_server.cpp b/ikvm_server.cpp
index 37a927b..35310da 100644
--- a/ikvm_server.cpp
+++ b/ikvm_server.cpp
@@ -154,6 +154,7 @@
     Server* server = (Server*)cl->screen->screenData;
 
     delete (ClientData*)cl->clientData;
+    cl->clientData = nullptr;
 
     if (server->numClients-- == 1)
     {
@@ -173,7 +174,6 @@
     {
         server->pendingResize = false;
         server->frameCounter = 0;
-        server->video.start();
     }
 
     return RFB_CLIENT_ACCEPT;