Remove tty from docker run
The current jenkins builds builds log output similar to below.
0: os-release-1.0-r0 do_package - 19s (pid 21095)
1: linux-aspeed-5.8.17+gitAUTOINC+3cc95ae407-r0 do_kernel_configme - 13s (pid 24148)
2: u-boot-fw-utils-aspeed-1_v2016.07+gitAUTOINC+1ded9fa3a2-r0 do_compile - 6s (pid 26799)
3: u-boot-aspeed-1_v2016.07+gitAUTOINC+1ded9fa3a2-r0 do_compile - 5s (pid 27354)
4: phosphor-fan-1.0+gitAUTOINC+11b5d8fcaf-r1 do_prepare_recipe_sysroot - 0s (pid 29825)
[444A[JCurrently 7 running tasks (5172 of 5633) 91% ||
0: os-release-1.0-r0 do_package - 19s (pid 21095)
1: linux-aspeed-5.8.17+gitAUTOINC+3cc95ae407-r0 do_kernel_configme - 13s (pid 24148)
2: u-boot-fw-utils-aspeed-1_v2016.07+gitAUTOINC+1ded9fa3a2-r0 do_compile - 6s (pid 26799)
3: u-boot-aspeed-1_v2016.07+gitAUTOINC+1ded9fa3a2-r0 do_compile - 5s (pid 27354)
4: phosphor-fan-1.0+gitAUTOINC+11b5d8fcaf-r1 do_prepare_recipe_sysroot - 0s (pid 29825)
[444A[JCurrently 7 running tasks (5173 of 5633) 91% ||
Every few seconds, which clogs up the log, and makes finding errors much
harder. This is because we have -t set on the docker run call, which
sets up a tty. Considering where it's located, it looks like someone just copied
it from the docker build call, in which -t indicates the tag name. -t in docker
run invokes the creation of a tty, and turns bitbake into interactive mode
This seems unintentional. If the -t is removed, the output looks like.
NOTE: recipe libpcre2-native-10.35-r0: task do_compile: Succeeded
NOTE: Running task 1734 of 6202 (virtual:native:/usr/local/google/home/edtanous/63968600/openbmc/meta/recipes-support/libpcre/libpcre2_10.35.bb:do_install)
NOTE: recipe libpcre-native-8.44-r0: task do_install: Succeeded
NOTE: Running task 1735 of 6202 (virtual:native:/usr/local/google/home/edtanous/63968600/openbmc/meta/recipes-support/libpcre/libpcre_8.44.bb:do_populate_sysroot)
NOTE: recipe libpcre2-native-10.35-r0: task do_install: Started
NOTE: recipe libpcre-native-8.44-r0: task do_populate_sysroot: Started
NOTE: recipe db-native-1_5.3.28-r1: task do_configure: Succeeded
NOTE: Running task 1736 of 6202 (virtual:native:/usr/local/google/home/edtanous/63968600/openbmc/meta/recipes-support/db/db_5.3.28.bb:do_compile)
NOTE: recipe db-native-1_5.3.28-r1: task do_compile: Started
NOTE: recipe libpcre2-native-10.35-r0: task do_install: Succeeded
NOTE: Running task 1737 of 6202 (virtual:native:/usr/local/google/home/edtanous/63968600/openbmc/meta/recipes-support/libpcre/libpcre2_10.35.bb:do_populate_sysroot)
NOTE: recipe libpcre-native-8.44-r0: task do_populate_sysroot: Succeeded
NOTE: Running task 1738 of 6202 (virtual:native:/usr/local/google/home/edtanous/63968600/openbmc/meta/recipes-support/libpcre/libpcre_8.44.bb:do_rm_work)
NOTE: recipe libpcre2-native-10.35-r0: task do_populate_sysroot: Started
NOTE: recipe libpcre-native-8.44-r0: task do_rm_work: Started
NOTE: recipe libpcre-native-8.44-r0: task do_rm_work: Succeeded
NOTE: Running noexec task 1739 of 6202 (virtual:native:/usr/local/google/home/edtanous/63968600/openbmc/meta/recipes-support/libpcre/libpcre_8.44.bb:do_build)
Which makes it much easier to find errors when scanning the log file,
and means in the future we can grep for errors.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I16a81ea3475cb27392582ab4c789fc5a62341873
diff --git a/build-setup.sh b/build-setup.sh
index 6252b77..f8e597d 100755
--- a/build-setup.sh
+++ b/build-setup.sh
@@ -474,7 +474,7 @@
${mount_ssc_dir} \
${mount_workspace_dir} \
--cpus="$num_cpu" \
--t "${img_name}" \
+"${img_name}" \
"${WORKSPACE}/build.sh"
# To maintain function of resources that used an older path, add a link