jenkins/userid-validation: simplify and fix shellcheck errors
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3320426809b1bc8860d9560457693eb1ea159e77
diff --git a/jenkins/userid-validation b/jenkins/userid-validation
index 250785d..e6ebebe 100755
--- a/jenkins/userid-validation
+++ b/jenkins/userid-validation
@@ -13,111 +13,87 @@
# SSH_KEY: Path to private ssh key used to post messages to gerrit
GERRIT_COMMAND="curl -s --anyauth -n https://gerrit.openbmc-project.xyz"
+GERRIT_SSH_CMD=( \
+ ssh -o 'StrictHostKeyChecking no' -i "$SSH_KEY" \
+ -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
+)
echo "Checking ${GERRIT_PROJECT}:${GERRIT_BRANCH}:${GERRIT_CHANGE_ID}:${GERRIT_PATCHSET_REVISION}"
-COMMITTER_EMAIL=`${GERRIT_COMMAND}/a/changes/${GERRIT_PROJECT/\//%2F}~${GERRIT_BRANCH}~${GERRIT_CHANGE_ID}/revisions/${GERRIT_PATCHSET_REVISION}/commit | python2 -c "import sys, json; sys.stdin.read(4); print json.load(sys.stdin)['committer']['email']"`
+# shellcheck disable=2086 # GERRIT_COMMAND is purposefully wordsplit.
+COMMITTER_EMAIL=$(${GERRIT_COMMAND}/a/changes/${GERRIT_PROJECT/\//%2F}~${GERRIT_BRANCH}~${GERRIT_CHANGE_ID}/revisions/${GERRIT_PATCHSET_REVISION}/commit | python3 -c "import sys, json; sys.stdin.read(4); print(json.load(sys.stdin)['committer']['email'])")
if [ "x${COMMITTER_EMAIL}" == "x" ]; then
echo "Unable to find committer."
- ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit review \
- ${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER} --label=Ok-To-Test=0 --message=\'Unable to determine committer\'
- exit -1
+ "${GERRIT_SSH_CMD[@]}" review \
+ "${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER}" \
+ --label=Ok-To-Test=0 "--message='Unable to determine committer'"
+ exit 1
fi
#echo "Commit by '${COMMITTER_EMAIL}'"
-COMMITTER_USERNAME=`${GERRIT_COMMAND}/a/accounts/${COMMITTER_EMAIL} | python2 -c "import sys, json; sys.stdin.read(4); print json.load(sys.stdin)['username']"`
+# shellcheck disable=2086 # GERRIT_COMMAND is purposefully wordsplit.
+COMMITTER_USERNAME=$(${GERRIT_COMMAND}/a/accounts/${COMMITTER_EMAIL} | python3 -c "import sys, json; sys.stdin.read(4); print(json.load(sys.stdin)['username'])")
#COMMITTER_USERNAME=`${GERRIT_COMMAND}/a/accounts/${COMMITTER_EMAIL}`
echo "USERNAME: $COMMITTER_USERNAME"
if [ "x${COMMITTER_USERNAME}" == "x" ]; then
echo "Unable to determine github user for ${COMMITTER_EMAIL}."
- ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit review \
- ${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER} --label=Ok-To-Test=0 --message=\'Unable to determine github user\'
- exit -1
+ "${GERRIT_SSH_CMD[@]}" review \
+ "${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER}" \
+ --label=Ok-To-Test=0 "--message='Unable to determine github user'"
+ exit 1
fi
# Reset the vote to 0 so jenkins will detect a new +1 on retriggers
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit review \
- ${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER} --label=Ok-To-Test=0 -t autogenerated:jenkins
+"${GERRIT_SSH_CMD[@]}" review \
+ "${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER}" \
+ --label=Ok-To-Test=0 -t autogenerated:jenkins
# Write full list of users to a file
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members openbmc/ci-authorized --recursive > $WORKSPACE/users.txt
+GERRIT_CI_GROUPS=( \
+ alibaba/ci-authorized \
+ amd/ci-authorized \
+ ampere/ci-authorized \
+ bytedance/ci-authorized \
+ facebook/ci-authorized \
+ gager-in/ci-authorized \
+ google/ci-authorized \
+ hcl/ci-authorized \
+ hpe/ci-authorized \
+ ibm/ci-authorized \
+ individual/ci-authorized \
+ inspur/ci-authorized \
+ intel/ci-authorized \
+ inventec/ci-authorized \
+ nuvoton/ci-authorized \
+ nvidia/ci-authorized \
+ openbmc/ci-authorized \
+ quanta/ci-authorized \
+ rcs/ci-authorized \
+ supermicro/ci-authorized \
+ wistron/ci-authorized \
+ wiwynn/ci-authorized \
+ yadro/ci-authorized \
+)
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members ampere/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members facebook/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members google/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members ibm/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members intel/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members inventec/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members nuvoton/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members quanta/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members yadro/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members inspur/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members wistron/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members hcl/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members rcs/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members wiwynn/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members hpe/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members individual/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members gager-in/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members amd/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members nvidia/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members bytedance/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members alibaba/ci-authorized --recursive >> $WORKSPACE/users.txt
-
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit \
- ls-members supermicro/ci-authorized --recursive >> $WORKSPACE/users.txt
+rm -f "$WORKSPACE/users.txt"
+for g in "${GERRIT_CI_GROUPS[@]}"; do
+ "${GERRIT_SSH_CMD[@]}" ls-members "$g" --recursive \
+ >> "$WORKSPACE/users.txt"
+done
# grep for the specific username word in the file
-if grep -q -w ${COMMITTER_USERNAME} $WORKSPACE/users.txt; then
- ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit review \
- ${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER} --label=Ok-To-Test=1 -t autogenerated:jenkins --message=\'User approved, CI ok to start\'
+if grep -q -w "${COMMITTER_USERNAME}" "$WORKSPACE/users.txt"; then
+ "${GERRIT_SSH_CMD[@]}" review \
+ "${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER}" \
+ --label=Ok-To-Test=1 -t autogenerated:jenkins \
+ "--message='User approved, CI ok to start'"
exit 0
fi
echo "${COMMITTER_USERNAME} is not on the approved list."
-ssh -o 'StrictHostKeyChecking no' -i $SSH_KEY -p 29418 jenkins-openbmc-ci@gerrit.openbmc-project.xyz gerrit review \
- ${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER} --label=Ok-To-Test=0 -t autogenerated:jenkins --message=\'User not approved, see admin, no CI\'
+"${GERRIT_SSH_CMD[@]}" review \
+ "${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER}" \
+ --label=Ok-To-Test=0 -t autogenerated:jenkins \
+ "--message='User not approved, see admin, no CI'"
exit 0