tree 44df176be50ee5875e2c764c4f1e9f31fbc99c16
parent d37b805ffcb94e49b9e0bdee4661cf0f2af69cc6
author Patrick Venture <venture@google.com> 1539388794 -0700
committer Patrick Venture <venture@google.com> 1539799875 +0000

build-unit-test-docker: add cppcheck static analysis tool

Add the cppcheck static analysis tool.  This tool's output is only for
information while it's being tuned.  The tool is meant to find security
flaws in cpp as well as finding performance improvements and style. In
this case, the style improvements have been primarily scope reduction
or using a standard library algorithm instead of a raw mechanism.

The author of a patch should check the log output from their presubmit
to see if this tool has identified anything.  The reviewers can also
check.

The tuning here refers to the configuration.  This tool was chosen
partially because it's under very active development and partially
because it's very quick.

If cppcheck reports a false positive, please file an issue against that
project including the pertinent information.

Change-Id: Ia43d4b9d0995dfa6667c2a8b09d072931936e437
Signed-off-by: Patrick Venture <venture@google.com>