commit d080969b2fde1cfcc41938b01db7c5f8c14331f0
author Andrew Jeffery <andrew@aj.id.au> Fri May 14 16:23:57 2021 +0930
committer Andrew Jeffery <andrew@aj.id.au> Fri May 14 16:27:03 2021 +0930
tree 59116574e578f8b172146477251db0242323a14f
parent 01370f2e7b881e027070edb2166b121891506e5c

unit-test: Define TEST_ONLY=1 to skip the analyse phase

The autotools build system driver was doing something quite different to
CMake and Meson. This makes it hard to document the behaviour of
TEST_ONLY=1.

Give it the consistent behaviour of skipping the analyse() phase in the
BuildSystem implementation.

Change-Id: I3a8986899cb96d274932263647e8a8b18fbeed49
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

scripts/unit-test.py

diff --git a/scripts/unit-test.py b/scripts/unit-test.py
index c1206fb..467b14e 100755
--- a/scripts/unit-test.py
+++ b/scripts/unit-test.py
@@ -678,11 +678,10 @@
             self._configure_feature('tests', build_for_testing),
             self._configure_feature('itests', INTEGRATION_TEST),
         ]
-        if not TEST_ONLY:
-            conf_flags.extend([
-                self._configure_feature('code-coverage', build_for_testing),
-                self._configure_feature('valgrind', build_for_testing),
-            ])
+        conf_flags.extend([
+            self._configure_feature('code-coverage', build_for_testing),
+            self._configure_feature('valgrind', build_for_testing),
+        ])
         # Add any necessary configure flags for package
         if CONFIGURE_FLAGS.get(self.package) is not None:
             conf_flags.extend(CONFIGURE_FLAGS.get(self.package))
@@ -703,6 +702,9 @@
             cmd = make_parallel + ['check']
             for i in range(0, args.repeat):
                 check_call_cmd(*cmd)
+
+            maybe_make_valgrind()
+            maybe_make_coverage()
         except CalledProcessError:
             for root, _, files in os.walk(os.getcwd()):
                 if 'test-suite.log' not in files:
@@ -711,8 +713,6 @@
             raise Exception('Unit tests failed')
 
     def analyze(self):
-        maybe_make_valgrind()
-        maybe_make_coverage()
         run_cppcheck()
 
 
@@ -746,9 +746,6 @@
             check_call_cmd('ctest', '.')
 
     def analyze(self):
-        if TEST_ONLY:
-            return
-
         if os.path.isfile('.clang-tidy'):
             try:
                 os.mkdir("tidy-build")
@@ -966,9 +963,6 @@
             raise Exception('Valgrind tests failed')
 
     def analyze(self):
-        if TEST_ONLY:
-            return
-
         self._maybe_valgrind()
 
         # Run clang-tidy only if the project has a configuration
@@ -1076,7 +1070,8 @@
         system.build()
         system.install()
         system.test()
-        system.analyze()
+        if not TEST_ONLY:
+            system.analyze()
 
     def test(self):
         for system in self.build_systems():