commit e414667050974e16eebe95b12ab22eb5f971ce18
author Nan Zhou <nanzhoumails@gmail.com> Fri Jan 28 21:37:16 2022 +0000
committer Andrew Geissler <geissonator@yahoo.com> Mon Jan 31 20:33:50 2022 +0000
tree 192e835fa6cdaff1dab1f5c6a101228c9ae1eafe
parent c2796fe8ab0de5e9033c2bceff799991e5d7df6b

qemu robot test: allow specifying IMAGE_LOC

The existing script assumes qemuarm and the MACHINE under test are
in the same folder. This change adds an option to specify a
different location for the MACHINE image.

Tested:
UPSTREAM_WORKSPACE=/home/nanzhou_google_com/openbmc
DEFAULT_IMAGE_LOC=./build/romulus/tmp/deploy/images
QEMU_BIN=./qemuarm/tmp/sysroots/x86_64/usr/bin/qemu-system-arm
MACHINE=romulus ./openbmc-build-scripts/run-qemu-robot
-test.sh

I cloned the openbmc distro in my home dir. Then source setup
qemuarm and romulus separately, and finished the builds.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I37800de63fe9d64dd28ffc6c5a4d3c0ea181a597

scripts/boot-qemu.sh

diff --git a/scripts/boot-qemu.sh b/scripts/boot-qemu.sh
index c07112e..fd52c9e 100755
--- a/scripts/boot-qemu.sh
+++ b/scripts/boot-qemu.sh
@@ -62,15 +62,14 @@
 # Find the correct drive file, and save its name.  OpenBMC has 3 different
 # image formats.  The UBI based one, the standard static.mtd one, and the
 # default QEMU basic image (rootfs.ext4).
-
-DEFAULT_IMAGE_LOC="./tmp/deploy/images/"
-if [ -f ${DEFAULT_IMAGE_LOC}/"${MACHINE}"/obmc-phosphor-image-"${MACHINE}".ubi.mtd ]; then
+DEFAULT_IMAGE_LOC="${DEFAULT_IMAGE_LOC:-./tmp/deploy/images/}"
+if [ -f "${DEFAULT_IMAGE_LOC}/${MACHINE}/obmc-phosphor-image-${MACHINE}".ubi.mtd ]; then
     DRIVE="obmc-phosphor-image-${MACHINE}.ubi.mtd"
-elif [ -f ${DEFAULT_IMAGE_LOC}/"${MACHINE}"/obmc-phosphor-image-"${MACHINE}".static.mtd ]; then
+elif [ -f "${DEFAULT_IMAGE_LOC}/${MACHINE}/obmc-phosphor-image-${MACHINE}".static.mtd ]; then
     DRIVE="obmc-phosphor-image-${MACHINE}.static.mtd"
 else
     # shellcheck disable=SC2010
-    DRIVE=$(ls ${DEFAULT_IMAGE_LOC}/qemuarm | grep rootfs.ext4)
+    DRIVE=$(ls "${DEFAULT_IMAGE_LOC}"/qemuarm | grep rootfs.ext4)
 fi
 
 # Copy the drive file off to /tmp so that QEMU does not write anything back
@@ -81,9 +80,9 @@
 # The drive file is stored in different locations depending on if we are
 # using the default or real platforms.
 if [ "${MACHINE}" = "${DEFAULT_MACHINE}" ]; then
-    cp ${DEFAULT_IMAGE_LOC}/qemuarm/"${DRIVE}" "${TMP_DRIVE_PATH}"
+    cp "${DEFAULT_IMAGE_LOC}/qemuarm/${DRIVE}" "${TMP_DRIVE_PATH}"
 else
-    cp ${DEFAULT_IMAGE_LOC}/"${MACHINE}"/"${DRIVE}" "${TMP_DRIVE_PATH}"
+    cp "${DEFAULT_IMAGE_LOC}/${MACHINE}/${DRIVE}" "${TMP_DRIVE_PATH}"
 fi
 
 # Obtain IP from /etc/hosts if IP is not valid set to localhost
@@ -124,9 +123,9 @@
         -serial mon:vc \
         -serial mon:stdio \
         -serial null \
-        -kernel ${DEFAULT_IMAGE_LOC}/qemuarm/zImage \
+        -kernel "${DEFAULT_IMAGE_LOC}"/qemuarm/zImage \
         -append 'root=/dev/vda rw highres=off  console=ttyS0 mem=256M ip=dhcp console=ttyAMA0,115200 console=tty'\
-        -dtb ${DEFAULT_IMAGE_LOC}/qemuarm/zImage-versatile-pb.dtb
+        -dtb "${DEFAULT_IMAGE_LOC}"/qemuarm/zImage-versatile-pb.dtb
 else
     # shellcheck disable=SC2086 # NIC is intentionally word-split.
     ${QEMU_BIN} \