commit 011c5f3b6e8054d2d53aa23e02b846b2ab372aa9
author Nagarjun B <nagarjunb@ami.com> Mon Jul 17 17:14:59 2023 +0530
committer George Keishing <gkeishin@gmail.com> Tue Jul 25 16:44:55 2023 +0000
tree 5e72b1a372ac6b809bd9513f02a68dc2408140fb
parent e4f518d6575897263ddef55ea37531356a31446a

Modified IPMI watchdog script for timer action validation

Added code to validate the watchdog timer action whether the
host/Chassis is performed the expected action.

Changed the power_state_change variable value to 3 sec.

Changed keyword from "Check If BMC Is Up" to "Is BMC Operational"
since old keyword using Rest to verfiy BMC is up or not so changed
it to redfish.

Tested: Ran ipmi/test_ipmi_watchdog.robot

Change-Id: I6ec66721fa7fba397789f1b9ed531dac97399955
Signed-off-by: Nagarjun B  <nagarjunb@ami.com>

ipmi/test_ipmi_watchdog.robot

diff --git a/ipmi/test_ipmi_watchdog.robot b/ipmi/test_ipmi_watchdog.robot
index 54834a2..bb776ba 100644
--- a/ipmi/test_ipmi_watchdog.robot
+++ b/ipmi/test_ipmi_watchdog.robot
@@ -12,7 +12,7 @@
 *** Variables ***
 
 ${TIMER_DELAY}          3
-${POWER_STATE_CHANGE}   20
+${POWER_STATE_CHANGE}   3
 
 *** Test Cases ***
 
@@ -193,7 +193,8 @@
 
     # Reset BMC.
     Run External IPMI Standard Command  mc reset cold -N 10 -R 1
-    Check If BMC is Up
+    Wait Until Keyword Succeeds  ${OPENBMC_REBOOT_TIMEOUT} min  10 sec
+    ...  Is BMC Operational
 
     # Reset Watchdog Timer without initialized watchdog.
     Run Keyword and Expect Error  *Unknown*
@@ -267,7 +268,19 @@
     # Delay for power state.
     Sleep  ${POWER_STATE_CHANGE}
 
-    Verify Host Power State  ${power_state}
+    IF  '${sel_event}' == 'Hard reset' or '${sel_event}' == 'Power cycle'
+        # If timer expire action is 'Hard Reset' then the host/chassis immediately powering on after
+        # timer expires. So, verify host is rebooting by expecting that host is unpingable.
+        Run Keyword If  '${sel_event}' == 'Power cycle'
+        ...  Wait Until Keyword Succeeds  1 min  10 sec  Verify Host Power State  ['off']
+        ...  ELSE
+        ...  Wait Until Keyword Succeeds  20 sec  5 sec  Is Host Unpingable  ${OS_HOST}
+        Wait Until Keyword Succeeds  5 min  30 sec  Verify Host Power State  ['on']
+        Wait Until Keyword Succeeds  7 min  30 sec  OS Execute Command  uptime
+    ELSE
+        Wait Until Keyword Succeeds  1 min  20 sec  Verify Host Power State  ${power_state}
+    END
+
     Verify Watchdog Timer Action SEL Event  ${sel_event}
 
 

lib/common_utils.robot

diff --git a/lib/common_utils.robot b/lib/common_utils.robot
index afe6f80..adb1fe1 100755
--- a/lib/common_utils.robot
+++ b/lib/common_utils.robot
@@ -984,6 +984,18 @@
     Should be equal  ${RC}  ${1}
 
 
+Is Host Unpingable
+    [Documentation]  Check if Given IP is unpingable.
+    [Arguments]  ${ip}
+
+    # Description of argument(s):
+    # ip           HostOS IP address (e.g. "10.7.7.7").
+
+    ${RC}  ${output}=  Run and return RC and Output  ping -c 4 ${ip}
+    Log  RC: ${RC}\nOutput:\n${output}
+    Should be equal  ${RC}  ${1}
+
+
 Redfish BMC Match States
     [Documentation]  Verify the BMC match state.
     [Arguments]  ${match_state}