commit 06de1f7903e629a361095eba16ca86d61fb9a753
author Michael Walsh <micwalsh@us.ibm.com> Mon Feb 17 14:28:24 2020 -0600
committer George Keishing <gkeishin@in.ibm.com> Mon Feb 17 23:02:25 2020 -0600
tree 3db6dc329470dd2a5c8574d75c8ed1955aeb0cb4
parent f188e4a000fcdd44911be59af0b0419725f08e36

Corrected incorrect use of Valid Value

This will correct this failure:

valid_values:                                     1.1.1 <str>
required_type:                                    list

In code like this:

    ${pldm_output}=  Pldmtool  ${pldm_cmd}
    Valid Value  pldm_output['type_0(base)']  ${VERSION_BASE['STRING']}

Change-Id: I39ee6077ece90503fd33220c4fe03f880ed2230d
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

pldm/test_pldm_base.robot

diff --git a/pldm/test_pldm_base.robot b/pldm/test_pldm_base.robot
index 77bfae7..d7f8dac 100644
--- a/pldm/test_pldm_base.robot
+++ b/pldm/test_pldm_base.robot
@@ -25,7 +25,7 @@
 
     ${pldm_cmd}=  Evaluate  $CMD_GETPLDMVERSION % 'base'
     ${pldm_output}=  Pldmtool  ${pldm_cmd}
-    Valid Value  pldm_output['type_0(base)']  ${VERSION_BASE['STRING']}
+    Valid Value  pldm_output['type_0(base)']  ['${VERSION_BASE['STRING']}']
 
 
 Verify Get PLDM Version For Platform
@@ -34,7 +34,7 @@
 
     ${pldm_cmd}=  Evaluate  $CMD_GETPLDMVERSION % 'platform'
     ${pldm_output}=  Pldmtool  ${pldm_cmd}
-    Valid Value  pldm_output['type_2(platform)']  ${VERSION_PLATFORM['STRING']}
+    Valid Value  pldm_output['type_2(platform)']  ['${VERSION_PLATFORM['STRING']}']
 
 
 Verify Get PLDM Version For BIOS
@@ -43,7 +43,7 @@
 
     ${pldm_cmd}=  Evaluate  $CMD_GETPLDMVERSION % 'bios'
     ${pldm_output}=  Pldmtool  ${pldm_cmd}
-    Valid Value  pldm_output['type_3(bios)']  ${VERSION_BIOS['STRING']}
+    Valid Value  pldm_output['type_3(bios)']  ['${VERSION_BIOS['STRING']}']
 
 
 Verify Get PLDM Version For FRU
@@ -52,4 +52,4 @@
 
     ${pldm_cmd}=  Evaluate  $CMD_GETPLDMVERSION % 'fru'
     ${pldm_output}=  Pldmtool  ${pldm_cmd}
-    Valid Value  pldm_output['type_4(fru)']  ${VERSION_FRU['STRING']}
+    Valid Value  pldm_output['type_4(fru)']  ['${VERSION_FRU['STRING']}']

pldm/test_pldm_bios.robot

diff --git a/pldm/test_pldm_bios.robot b/pldm/test_pldm_bios.robot
index 7c66a6d..0413e16 100644
--- a/pldm/test_pldm_bios.robot
+++ b/pldm/test_pldm_bios.robot
@@ -51,12 +51,12 @@
     # Set date.
     ${cmd_set_date}=  Evaluate  $CMD_SETDATETIME % '${upgrade_date}'
     ${pldm_output}=  Pldmtool  ${cmd_set_date}
-    Valid Value  pldm_output['setdatetime']  'SUCCESS'
+    Valid Value  pldm_output['setdatetime']  ['SUCCESS']
 
     # Set time.
     ${cmd_set_time}=  Evaluate  $CMD_SETDATETIME % '${upgrade_time}'
     ${pldm_output}=  Pldmtool  ${cmd_set_time}
-    Valid Value  pldm_output['setdatetime']  'SUCCESS'
+    Valid Value  pldm_output['setdatetime']  ['SUCCESS']
 
 *** Keywords ***
 
@@ -68,4 +68,4 @@
     ${current_date_time}=  Evaluate  re.sub(r'-* *:*', "", '${result}')  modules=re
     ${cmd_set_date_time}=  Evaluate  $CMD_SETDATETIME % '${current_date_time}'
     ${pldm_output}=  Pldmtool  ${cmd_set_date_time}
-    Valid Value  pldm_output['setdatetime']  'SUCCESS'
+    Valid Value  pldm_output['setdatetime']  ['SUCCESS']