tree 496518a28b4428076c4ef8c1ad12adfd2f7b53a3
parent 8ba1ebdfe6ae07ec81f7e4cfb433af0bce4de4a1
author Michael Walsh <micwalsh@us.ibm.com> 1581612700 -0600
committer George Keishing <gkeishin@in.ibm.com> 1581914851 +0000

Validation of list args for valid_values()

Added code to ensure that valid_values and invalid_values are lists.
If they are not, the user can get unexpected results.

Example:

var1 = 'enabled'
valid_value(var1, valid_values='enableddd')

In this case, valid_values is a string so when the function does this:

if var1 in valid_values:

The answer will be "yes" so will will get an incorrect validation.

The correct invocation should be this:

valid_value(var1, valid_values=['enableddd'])

Which correctly yields a failure:

var1:                                             enabled <str>

It must be one of the following values:

valid_values: <list>
  [0]:                                            enableddd <str>

Change-Id: I2d10a00a4cc372af4c2eacc0dc33afbaa0ccf3a7
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>