commit 12be4b4169987a08170229badcdccade1d5db3a2
author Ashwini Chandrappa <Ashwini.Chandrappa777@ibm.com> Tue Mar 15 23:02:07 2022 -0500
committer George Keishing <gkeishin@gmail.com> Mon May 02 06:27:53 2022 +0000
tree 9bf3e289e8cef91046b78489c06cc24e251386d2
parent 97c44657c963742e9334402cc269b5e0954e733f

Fix for IPMI non-root user delete

Change-Id: I2b41ab67128c62408eb0a51453535507ddc1870a
Signed-off-by: Ashwini Chandrappa <Ashwini.Chandrappa777@ibm.com>

ipmi/test_ipmi_user.robot

diff --git a/ipmi/test_ipmi_user.robot b/ipmi/test_ipmi_user.robot
index a9d1857..ba6301f 100644
--- a/ipmi/test_ipmi_user.robot
+++ b/ipmi/test_ipmi_user.robot
@@ -7,6 +7,7 @@
 Library             ../lib/ipmi_utils.py
 Test Setup          Printn
 
+Suite Setup         Suite Setup Execution
 Test Teardown       Test Teardown Execution
 
 *** Variables ***
@@ -36,23 +37,19 @@
     [Documentation]  Verify IPMI maximum supported IPMI user ID and
     ...  enabled user form user summary
     [Tags]  Verify_IPMI_User_Summary
-    [Teardown]  Run Keywords  FFDC On Test Case Fail  AND
-    ...  Delete Created User  ${random_userid}
-    # Delete all non-root IPMI (i.e. except userid 1)
-    Delete All Non Root IPMI User
+    [Teardown]  Run Keywords  FFDC On Test Case Fail  AND  Delete Created User  ${random_userid}
 
+    # Create random user
     ${random_userid}  ${random_username}=  Create Random IPMI User
     Set Test Variable  ${random_userid}
     Run IPMI Standard Command  user enable ${random_userid}
 
-    # Verify maximum user count IPMI local user can have. Also verify
-    # currently enabled users.
-    ${resp}=  Wait Until Keyword Succeeds  15 sec  5 sec  Run IPMI Standard Command
-    ...  user summary ${CHANNEL_NUMBER}
-    ${enabled_user_count}=
-    ...  Get Lines Containing String  ${resp}  Enabled User Count
-    ${maximum_ids}=  Get Lines Containing String  ${resp}  Maximum IDs
-    Should Contain  ${enabled_user_count}  2
+    ${output}=  Run IPMI Standard Command  user summary ${CHANNEL_NUMBER}
+    # TODO: Verification of enabled IPMI user needs to be done.
+    # https://github.com/openbmc/openbmc-test-automation/issues/2189
+
+    ${maximum_ids}=  Get Lines Containing String  ${output}  Maximum IDs
+
     Should Contain  ${maximum_ids}  15
 
 
@@ -670,3 +667,15 @@
     END
 
     Set Suite Variable  ${secondary_channel_number}
+
+
+Suite Setup Execution
+    [Documentation]  Check for the enabled user.
+
+    # Check for the enabled user count
+    ${resp}=  Run IPMI Standard Command  user summary ${CHANNEL_NUMBER}
+    ${enabled_user_count}=
+    ...  Get Lines Containing String  ${resp}  Enabled User Count
+
+    Should not contain  ${enabled_user_count}  15
+    ...  msg=IPMI have reached maximum user count