commit 15352054afc164c088ba20490241826aaf82bda8
author George Keishing <gkeishin@in.ibm.com> Thu Apr 24 18:55:47 2025 +0530
committer George Keishing <gkeishin@in.ibm.com> Fri Apr 25 16:34:56 2025 +0000
tree d9187e141e218f656944dd87fec0817b04954ff8
parent 934d3b03a79d888866d5f81012b0f6283ec7c6e5

FFDC code fix using pyflake

Changes:
   - Fixed the following error
     ffdc/ffdc_collector.py:56:9:
     local variable 'e' is assigned to but never used

     ffdc/ffdc_collector.py:913:21: undefined name 'self'
     ffdc/ffdc_collector.py:918:21: undefined name 'self'
     ffdc/ffdc_collector.py:1356:9:
     local variable 'env_vars_list' is assigned to but never used

     ffdc/lib/ssh_utility.py:67:9:
     local variable 'e' is assigned to but never used

     ffdc/plugins/redfish.py:8:1: 'os' imported but unused

Tested:
   - pyflake ffdc/
   - Tested the changes on sandbox
Change-Id: Ib4e774e1e7e16b49a36a5a00e35d6e60b4868715
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

ffdc/ffdc_collector.py

diff --git a/ffdc/ffdc_collector.py b/ffdc/ffdc_collector.py
index 6044e5e..c99873f 100644
--- a/ffdc/ffdc_collector.py
+++ b/ffdc/ffdc_collector.py
@@ -54,6 +54,7 @@
         try:
             plugin = __import__(plugin_module, globals(), locals(), [], 0)
         except Exception as e:
+            print("PLUGIN: Exception: %s" % e)
             print("PLUGIN: Module import failed: %s" % module)
             pass
 except FileNotFoundError as e:
@@ -910,12 +911,12 @@
             except (IOError, OSError) as e:
                 # PermissionError
                 if e.errno == EPERM or e.errno == EACCES:
-                    self.logger.error(
+                    print(
                         "\tERROR: os.makedirs %s failed with"
                         " PermissionError.\n" % dir_path
                     )
                 else:
-                    self.logger.error(
+                    print(
                         "\tERROR: os.makedirs %s failed with %s.\n"
                         % (dir_path, e.strerror)
                     )
@@ -1353,7 +1354,6 @@
                   yaml_arg_list:  [arg2, arg2]
         """
         # Get the env loaded keys as list ['hostname', 'username', 'password'].
-        env_vars_list = list(self.env_dict)
 
         if isinstance(yaml_arg_list, list):
             tmp_list = []

ffdc/lib/ssh_utility.py

diff --git a/ffdc/lib/ssh_utility.py b/ffdc/lib/ssh_utility.py
index 77ad8bb..73cdd9c 100644
--- a/ffdc/lib/ssh_utility.py
+++ b/ffdc/lib/ssh_utility.py
@@ -72,6 +72,7 @@
             socket.error,
         ) as e:
             is_ssh_login = False
+            print("SSH Login: Exception: %s" % e)
 
         return is_ssh_login
 

ffdc/plugins/redfish.py

diff --git a/ffdc/plugins/redfish.py b/ffdc/plugins/redfish.py
index 0c4211f..92dcdd0 100644
--- a/ffdc/plugins/redfish.py
+++ b/ffdc/plugins/redfish.py
@@ -5,7 +5,6 @@
 """
 
 import json
-import os
 import subprocess
 
 ERROR_RESPONSE = {