commit 1f8baa2298f41f648bc9d11bf3485c1f06e146cd
author George Keishing <gkeishin@in.ibm.com> Thu May 15 23:50:56 2025 +0530
committer George Keishing <gkeishin@in.ibm.com> Sun May 18 06:56:28 2025 +0000
tree 797d832fd20695d8d4b039a86f976de1be437544
parent a64fa5fa6ba06a50b5ee9f193279a7bc8e5b20e6

IPMI robot codes with latest directives

Changes:
   - Run KeyWord If is deprecated since Robot
     Framework version 5.*, use 'IF' instead

Tested:
   - Checked using robot dry-run to make sure the
     syntax is not broken
Change-Id: I8a52aeb2939104f2c94f294272d92c4a7692970e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

ipmi/test_ipmi_cold_reset.robot

diff --git a/ipmi/test_ipmi_cold_reset.robot b/ipmi/test_ipmi_cold_reset.robot
index 491b8c8..77617b2 100644
--- a/ipmi/test_ipmi_cold_reset.robot
+++ b/ipmi/test_ipmi_cold_reset.robot
@@ -165,43 +165,49 @@
     ${ipmi_lower_non_recoverable_threshold}=  Set Variable  ${get_ipmi_lower_non_recoverable_threshold.strip()}
     ${lower_non_recoverable_threshold_status}=  Run Keyword And Return Status  Should Not Contain
     ...  ${ipmi_lower_non_recoverable_threshold}  na
-    Run Keyword If  '${lower_non_recoverable_threshold_status}' == 'True'
-    ...  Set To Dictionary  ${tmp_dict}  lnr  ${ipmi_lower_non_recoverable_threshold}
+    IF  '${lower_non_recoverable_threshold_status}' == 'True'
+        Set To Dictionary  ${tmp_dict}  lnr  ${ipmi_lower_non_recoverable_threshold}
+    END
 
     ${get_ipmi_lower_critical_threshold}=  Get From List  ${ipmi_sensor}  5
     ${ipmi_lower_critical_threshold}=  Set Variable  ${get_ipmi_lower_critical_threshold.strip()}
     ${lower_critical_threshold_status}=  Run Keyword And Return Status  Should Not Contain
     ...  ${ipmi_lower_critical_threshold}  na
-    Run Keyword If  '${lower_critical_threshold_status}' == 'True'
-    ...  Set To Dictionary  ${tmp_dict}  lcr  ${ipmi_lower_critical_threshold}
+    IF  '${lower_critical_threshold_status}' == 'True'
+        Set To Dictionary  ${tmp_dict}  lcr  ${ipmi_lower_critical_threshold}
+    END
 
     ${get_ipmi_lower_non_critical_threshold}=  Get From List  ${ipmi_sensor}  6
     ${ipmi_lower_non_critical_threshold}=  Set Variable  ${get_ipmi_lower_non_critical_threshold.strip()}
     ${lower_non_critical_threshold_status}=  Run Keyword And Return Status  Should Not Contain
     ...  ${ipmi_lower_non_critical_threshold}  na
-    Run Keyword If  '${lower_non_critical_threshold_status}' == 'True'
-    ...  Set To Dictionary  ${tmp_dict}  lnc  ${ipmi_lower_non_critical_threshold}
+    IF  '${lower_non_critical_threshold_status}' == 'True'
+        Set To Dictionary  ${tmp_dict}  lnc  ${ipmi_lower_non_critical_threshold}
+    END
 
     ${get_ipmi_upper_non_critical_threshold}=  Get From List  ${ipmi_sensor}  7
     ${ipmi_upper_non_critical_threshold}=  Set Variable  ${get_ipmi_upper_non_critical_threshold.strip()}
     ${upper_non_critical_threshold_status}=  Run Keyword And Return Status  Should Not Contain
     ...  ${ipmi_upper_non_critical_threshold}  na
-    Run Keyword If  '${upper_non_critical_threshold_status}' == 'True'
-    ...  Set To Dictionary  ${tmp_dict}  unc  ${ipmi_upper_non_critical_threshold}
+    IF  '${upper_non_critical_threshold_status}' == 'True'
+        Set To Dictionary  ${tmp_dict}  unc  ${ipmi_upper_non_critical_threshold}
+    END
 
     ${get_ipmi_upper_critical_threshold}=  Get From List  ${ipmi_sensor}  8
     ${ipmi_upper_critical_threshold}=  Set Variable  ${get_ipmi_upper_critical_threshold.strip()}
     ${upper_critical_threshold_status}=  Run Keyword And Return Status  Should Not Contain
     ...  ${ipmi_upper_critical_threshold}  na
-    Run Keyword If  '${upper_critical_threshold_status}' == 'True'
-    ...  Set To Dictionary  ${tmp_dict}  ucr  ${ipmi_upper_critical_threshold}
+    IF  '${upper_critical_threshold_status}' == 'True'
+        Set To Dictionary  ${tmp_dict}  ucr  ${ipmi_upper_critical_threshold}
+    END
 
     ${get_ipmi_upper_non_recoverable_threshold}=  Get From List  ${ipmi_sensor}  9
     ${ipmi_upper_non_recoverable_threshold}=  Set Variable  ${get_ipmi_upper_non_recoverable_threshold.strip()}
     ${upper_non_recoverable_threshold_status}=  Run Keyword And Return Status  Should Not Contain
     ...  ${ipmi_upper_non_recoverable_threshold}  na
-    Run Keyword If  '${upper_non_recoverable_threshold_status}' == 'True'
-    ...  Set To Dictionary  ${tmp_dict}  unr  ${ipmi_upper_non_recoverable_threshold}
+    IF  '${upper_non_recoverable_threshold_status}' == 'True'
+        Set To Dictionary  ${tmp_dict}  unr  ${ipmi_upper_non_recoverable_threshold}
+    END
 
     RETURN  ${random_sensor_name}  ${tmp_dict}