Redfish BMC Reset Operation must tolerate logout error
- When a BMC reset is done, naturally the BMC quits communicating and
therefore the logout command may fail. Added code to tolerate this failure.
- Also capitalized "Redfish" where appropriate (cosmetic)
- Removed code to check REST resp.status. This is now done automatically by
redfish_plus.py.
Change-Id: I4ffcaf7c8902c90eb807ea1b87915ae305ddf5e4
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>
diff --git a/lib/bmc_redfish_utils.robot b/lib/bmc_redfish_utils.robot
index c20139f..86591f3 100644
--- a/lib/bmc_redfish_utils.robot
+++ b/lib/bmc_redfish_utils.robot
@@ -27,12 +27,11 @@
# }
# }
- redfish.Login
+ Redfish.Login
${target}= redfish_utils.Get Target Actions /redfish/v1/Systems/system/ ComputerSystem.Reset
${payload}= Create Dictionary ResetType=${reset_type}
- ${resp}= redfish.Post ${target} body=&{payload}
- Should Be Equal As Strings ${resp.status} ${HTTP_OK}
- redfish.Logout
+ ${resp}= Redfish.Post ${target} body=&{payload}
+ Redfish.Logout
Redfish BMC Reset Operation
@@ -47,9 +46,10 @@
# "target": "/redfish/v1/Managers/bmc/Actions/Manager.Reset"
# }
- redfish.Login
+ Redfish.Login
${target}= redfish_utils.Get Target Actions /redfish/v1/Managers/bmc/ Manager.Reset
${payload}= Create Dictionary ResetType=GracefulRestart
- ${resp}= redfish.Post ${target} body=&{payload}
- Should Be Equal As Strings ${resp.status} ${HTTP_OK}
- redfish.Logout
+ ${resp}= Redfish.Post ${target} body=&{payload}
+ # The logout may very well fail because the system was just asked to
+ # reset itself.
+ Run Keyword And Ignore Error Redfish.Logout