commit 27d779d0add02004135109613bbbd1c09f27eb24
author ishwaryamathim <ishwaryamm@ami.com> Fri Nov 10 05:42:47 2023 +0000
committer George Keishing <gkeishin@gmail.com> Tue Nov 14 10:18:23 2023 +0000
tree c0a2150da2b300221d35be81bb802e0218dbfc31
parent 0148f20f0c078d0838518c5b7458eda00de9b6a8

IPMI: Changed the fail_on_err=0 param and Modified Test Invalid IPMI Channel Response in test_ipmi_network_verification.robot

Changes:
   - Changed the fail_on_err=0 param which is misplaced in the testcase Verify Invalid Set MAC Address Via IPMI and testcase
     Verify Get And Set MAC Address Via IPMI. Also in keyword Set Default Mac And Verify
   - Modified script considering invalid channel list in testcase Test Invalid IPMI Channel Response

Tested:
   - Ran ipmi/test_ipmi_network_verification.robot

Change-Id: I65a218a5fcc1eaa0f69c6364e816b50123060065
Signed-off-by: Ishwarya Mathi M <ishwaryamm@ami.com>

ipmi/test_ipmi_network_verification.robot

diff --git a/ipmi/test_ipmi_network_verification.robot b/ipmi/test_ipmi_network_verification.robot
index bc06034..8e23347 100644
--- a/ipmi/test_ipmi_network_verification.robot
+++ b/ipmi/test_ipmi_network_verification.robot
@@ -71,20 +71,18 @@
     [Documentation]  Verify invalid IPMI channels supported response.
     [Tags]  Test_Invalid_IPMI_Channel_Response
 
-    ${channel_count}=  Get Physical Network Interface Count
-
-    # To target invalid channel, increment count.
-    ${channel_number}=  Evaluate  ${channel_count} + 1
-
     # Example of invalid channel:
     # $ ipmitool -I lanplus -H xx.xx.xx.xx -P password lan print 3
     # Get Channel Info command failed: Parameter out of range
     # Invalid channel: 3
 
-    ${stdout}=  Run External IPMI Standard Command
-    ...  lan print ${channel_number}  fail_on_err=${0}
-    Should Contain  ${stdout}  Invalid channel
-    ...  msg=IPMI channel ${channel_number} is invalid but seen working.
+    @{inactive_channel_list}=  Get Invalid Channel Number List
+    FOR  ${channel_number}  IN  @{inactive_channel_list}
+        ${stdout}=  Run IPMI Standard Command
+        ...  lan print ${channel_number}  fail_on_err=${0}
+        Should Contain  ${stdout}  Invalid channel
+        ...  msg=IPMI channel ${channel_number} is invalid but seen working.
+    END
 
 
 Get IP Address Source And Verify Using Redfish
@@ -205,8 +203,8 @@
 
     # Set MAC Address with invalid data.
     ${cmd}=  Catenate  ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} ${CHANNEL_NUMBER}
-    ...  0x05 ${Invalid_mac_address_hex}  fail_on_err=0
-    ${ipmi_set_output}=  Run Inband IPMI Raw Command  ${cmd}
+    ...  0x05 ${Invalid_mac_address_hex}
+    ${ipmi_set_output}=  Run Inband IPMI Raw Command  ${cmd}  fail_on_err=0
 
     Should Contain  ${ipmi_set_output}  ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][3]}
 
@@ -222,8 +220,8 @@
 
     # Set the MAC address.
     ${cmd}=  Catenate  ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} ${CHANNEL_NUMBER}
-    ...  0x05 ${mac_address_hex}  fail_on_err=0
-    ${ipmi_set_output}=  Run Inband IPMI Raw Command  ${cmd}
+    ...  0x05 ${mac_address_hex}
+    ${ipmi_set_output}=  Run Inband IPMI Raw Command  ${cmd}  fail_on_err=0
 
     # Get the MAC address and verify.
     ${ipmi_output}=  Run Inband IPMI Raw Command
@@ -370,8 +368,8 @@
 
     # Set the Default MAC address.
     ${cmd}=  Catenate  ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} ${CHANNEL_NUMBER}
-    ...  0x05 ${default_mac_address_hex}  fail_on_err=0
-    ${ipmi_set_output}=  Run Inband IPMI Raw Command  ${cmd}
+    ...  0x05 ${default_mac_address_hex}
+    ${ipmi_set_output}=  Run Inband IPMI Raw Command  ${cmd}  fail_on_err=0
 
     # check whether the default MAC is set.
     ${ipmi_get_mac}=  Run Inband IPMI Raw Command