commit 28f740559d203aad0eb66dd249b6722cd09a2d9d
author George Keishing <gkeishin@in.ibm.com> Mon Jul 20 09:02:50 2020 -0500
committer George Keishing <gkeishin@in.ibm.com> Wed Jul 22 11:44:10 2020 -0500
tree a35f279c2dcb90514117681f9bb301959e1bf6c1
parent 42ade549ca362677d880fac47d3ce70811bedf7e

Update fan sensors code check

Changes:
     - Remove Scale unit from the validation.
     - Update example note.

Resolves  openbmc/openbmc-test-automation#2096

Change-Id: Ifbaf5cbe142f78af805bb4d698aa3cce7d405137
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

tests/test_hardware_sensors.robot

diff --git a/tests/test_hardware_sensors.robot b/tests/test_hardware_sensors.robot
index 2d2d40b..8fb1676 100644
--- a/tests/test_hardware_sensors.robot
+++ b/tests/test_hardware_sensors.robot
@@ -37,29 +37,37 @@
 Verify Fan Sensors Attributes
    [Documentation]  Check fan attributes.
    [Tags]  Verify_Fan_Sensor_Attributes
+
    # Example:
-   # /xyz/openbmc_project/sensors/fan_tach/fan0
-   # /xyz/openbmc_project/sensors/fan_tach/fan1
-   # /xyz/openbmc_project/sensors/fan_tach/fan2
-   # /xyz/openbmc_project/sensors/fan_tach/fan3
+   # "/xyz/openbmc_project/sensors/fan_tach/fan0_0",
+   # "/xyz/openbmc_project/sensors/fan_tach/fan0_1",
+   # "/xyz/openbmc_project/sensors/fan_tach/fan1_0",
+   # "/xyz/openbmc_project/sensors/fan_tach/fan1_1",
+   # "/xyz/openbmc_project/sensors/fan_tach/fan2_0",
+   # "/xyz/openbmc_project/sensors/fan_tach/fan2_1",
+   # "/xyz/openbmc_project/sensors/fan_tach/fan3_0",
+   # "/xyz/openbmc_project/sensors/fan_tach/fan3_1"
+
    ${fans}=  Get Endpoint Paths  /xyz/openbmc_project/sensors/  fan*
 
    # Access the properties of the fan and it should contain
    # the following entries:
-   # /xyz/openbmc_project/sensors/fan_tach/fan0
+   # /xyz/openbmc_project/sensors/fan_tach/fan0_0
    # {
-   #     "Scale": 0,
-   #     "Target": 0,
+   #     "Functional": true,
+   #     "MaxValue": 0.0,
+   #     "MinValue": 0.0,
+   #     "Target": 10500,
    #     "Unit": "xyz.openbmc_project.Sensor.Value.Unit.RPMS",
-   #     "Value": 0
+   #     "Value": 0.0
    # }
 
    FOR  ${entry}  IN  @{fans}
      ${resp}=  OpenBMC Get Request  ${entry}
      ${json}=  To JSON  ${resp.content}
-     Should Be True  ${json["data"]["Scale"]} >= 0
      Run Keyword And Ignore Error  Should Be True  ${json["data"]["Target"]} >= 0
-     Should Be Equal As Strings  ${json["data"]["Unit"]}  xyz.openbmc_project.Sensor.Value.Unit.RPMS
+     Run Keyword And Ignore Error  Should Be Equal As Strings
+     ...  ${json["data"]["Unit"]}  xyz.openbmc_project.Sensor.Value.Unit.RPMS
      Should Be True  ${json["data"]["Value"]} >= 0
    END