commit 290b8bd242b3f37b7a7cacadaacd1aedfe2271a0
author Charles Paul Hofer <Charles.Hofer@ibm.com> Tue Sep 26 10:02:22 2017 -0500
committer George Keishing <gkeishin@in.ibm.com> Wed Sep 27 15:22:46 2017 +0000
tree 9a31bde231c09f783d74d1e86a31efac6db75527
parent b7842a5947488476ad689c16262e1fcee1e40530

Fix image activation BlockTransition timing error

Change-Id: I6230a575c0ff1468cb2b13f33fd930434c34ff75
Signed-off-by: Charles Paul Hofer <Charles.Hofer@ibm.com>

lib/code_update_utils.py

diff --git a/lib/code_update_utils.py b/lib/code_update_utils.py
index 6b6254b..252a6eb 100644
--- a/lib/code_update_utils.py
+++ b/lib/code_update_utils.py
@@ -108,13 +108,27 @@
 
     keyword.run_key_u("Open Connection And Log In")
     retry = 0
+    num_read_errors = 0
+    read_fail_threshold = 1
     while (retry < 20):
+        # TODO: Use retry option in run_key when available.
         status, software_state = keyword.run_key("Read Properties  " +
-                                    var.SOFTWARE_VERSION_URI + str(version_id))
+                                    var.SOFTWARE_VERSION_URI + str(version_id),
+                                    ignore=1)
+        if status == 'FAIL':
+            num_read_errors += 1
+            if num_read_errors > read_fail_threshold:
+                message = "Read errors exceeds threshold:\n " \
+                        + gp.sprint_vars(num_read_errors, read_fail_threshold)
+                BuiltIn().fail(message)
+            time.sleep(30)
+            continue
+
         current_state = (software_state)["Activation"]
         if (initial_state == current_state):
             time.sleep(60)
             retry += 1
+            num_read_errors = 0
         else:
             return
     return