Add BMC bad image tests and refactored PNOR bad image tests.

Add test cases for bad BMC images and refactored PNOR test cases
to use common code and reduce duplication.

Resolves openbmc/openbmc-test-automation#767

Change-Id: I73096b04f6a8e6a9ea318457c02710ff49934975
Signed-off-by: Charles P. Hofer <charles.hofer@ibm.com>
diff --git a/extended/test_uploadimage.py b/extended/test_uploadimage.py
index c9aa338..ddffe08 100644
--- a/extended/test_uploadimage.py
+++ b/extended/test_uploadimage.py
@@ -188,7 +188,7 @@
     """
 
     grk.run_key('Open Connection And Log In')
-    upload_dir_path = BuiltIn().get_variable_value("${UPLOAD_DIR_PATH}")
+    upload_dir_path = BuiltIn().get_variable_value("${upload_dir_path}")
     for i in range(6):
         stat, grep_res = grk.run_key('Execute Command On BMC  '
                 + 'ls ' + upload_dir_path + '*/MANIFEST 2>/dev/null '