Fix for Date and Time
Changes:
- Made status code changes for Redfish date and time.
Tested:
- Ran testcase from sandbox successfully.
Change-Id: Ic7824bccd431f75634df69ccf0a47db42058822e
Signed-off-by: sarandev3 <saranyad@in.ibm.com>
diff --git a/lib/bmc_date_and_time_utils.robot b/lib/bmc_date_and_time_utils.robot
index 9f532fe..47531e1 100644
--- a/lib/bmc_date_and_time_utils.robot
+++ b/lib/bmc_date_and_time_utils.robot
@@ -45,8 +45,8 @@
# Change date format to 2024-03-07T07:58:50+00:00 from 2024-03-07 07:58:50.000.
IF "T" in "${date_time}"
Wait Until Keyword Succeeds 1min 5sec
- ... Redfish.Patch ${REDFISH_BASE_URI}Managers/${MANAGER_ID} body={'DateTime': '${date_time}'}
- ... &{kwargs} valid_status_codes=[${HTTP_OK}, ${HTTP_NO_CONTENT}]
+ ... Redfish.Patch ${REDFISH_BASE_URI}Managers/${MANAGER_ID}
+ ... body={'DateTime': '${date_time}'} &{kwargs}
ELSE
${date_time_formatted}= Convert Date ${date_time} result_format=%Y-%m-%dT%H:%M:%S+00:00
Wait Until Keyword Succeeds 1min 5sec
diff --git a/redfish/managers/test_managers_bmc_time.robot b/redfish/managers/test_managers_bmc_time.robot
index ff32078..377de31 100644
--- a/redfish/managers/test_managers_bmc_time.robot
+++ b/redfish/managers/test_managers_bmc_time.robot
@@ -13,11 +13,8 @@
*** Variables ***
${max_time_diff_in_seconds} 6
-# The "offset" consists of the value "26" specified for hours. Redfish will
-# convert that to the next day + 2 hours.
${date_time_with_offset} 2019-04-25T26:24:46+00:00
-${expected_date_time} 2019-04-26T02:24:46+00:00
-${invalid_datetime} "2019-04-251T12:24:46+00:00"
+${invalid_datetime} 2019-04-251T12:24:46+00:00
*** Test Cases ***
@@ -62,15 +59,7 @@
[Tags] Verify_Set_DateTime_With_Offset_Using_Redfish
[Teardown] Run Keywords Redfish Set DateTime AND FFDC On Test Case Fail
- Redfish Set DateTime ${date_time_with_offset}
- ${cli_bmc_time}= CLI Get BMC DateTime
-
- ${date_time_diff}= Subtract Date From Date ${cli_bmc_time}
- ... ${expected_date_time} exclude_millis=yes
- ${date_time_diff}= Convert to Integer ${date_time_diff}
- Rprint Vars date_time_with_offset expected_date_time cli_bmc_time
- ... date_time_diff max_time_diff_in_seconds
- Valid Range date_time_diff 0 ${max_time_diff_in_seconds}
+ Redfish Set DateTime ${date_time_with_offset} valid_status_codes=[${HTTP_BAD_REQUEST}]
Verify Set DateTime With Invalid Data Using Redfish