Robot Framework 7.0 changes
Update robot code syntax overall in the repo
Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the 'RETURN' statement instead.
- Singular section headers like '*** Test Case ***'
are deprecated. Use plural format like
'*** Test Cases ***' instead.
- Singular section headers like '*** Variable ***'
are deprecated
Tested:
- Ran from sandbox with the version
$ robot --version
Robot Framework 7.0 (Python 3.10.12 on linux)
and also tested on latest python version
Robot Framework 7.0 (Python 3.11.9 on linux)
Change-Id: I54e85f9d799556c63b9a39f79483f83e9b980768
Signed-off-by: George Keishing <gkeishin@in.ibm.com>
diff --git a/lib/dump_utils.robot b/lib/dump_utils.robot
index 02b203c..b2ce90c 100644
--- a/lib/dump_utils.robot
+++ b/lib/dump_utils.robot
@@ -61,7 +61,7 @@
Wait Until Keyword Succeeds 3 min 15 sec Check Dump Existence
... ${dump_id}
- [Return] ${dump_id}
+ RETURN ${dump_id}
Check For Too Many Dumps
@@ -93,7 +93,7 @@
${status}= Run Keyword If ${too_many_dumps} Set Variable ${EMPTY}
... ELSE Fail msg=${exception}.
- [Return] ${status}
+ RETURN ${status}
Verify No Dump In Progress
@@ -180,7 +180,7 @@
${resp}= Redfish.Get ${REDFISH_SYSTEM_DUMP}
- [Return] ${resp.dict}
+ RETURN ${resp.dict}
Get Redfish BMC Dump Log Entries
@@ -188,7 +188,7 @@
${resp}= Redfish.Get ${REDFISH_DUMP_URI}
- [Return] ${resp.dict}
+ RETURN ${resp.dict}
Redfish Delete All System Dumps
@@ -258,7 +258,7 @@
... Set Global Variable ${DUMP_ENTRY_URI} /xyz/openbmc_project/dump/entry/
${dump_entries}= Get URL List ${DUMP_ENTRY_URI}
- [Return] ${dump_entries}
+ RETURN ${dump_entries}
Trigger Core Dump
[Documentation] Trigger core dump.
@@ -287,7 +287,7 @@
# "TaskState": "Running",
# "TaskStatus": "OK"
- [Return] ${resp.dict['Id']}
+ RETURN ${resp.dict['Id']}
Create User Initiated BMC Dump Via Redfish
[Documentation] Generate user initiated BMC dump via Redfish and return the dump id number (e.g., "5").
@@ -332,7 +332,7 @@
# "TargetUri": "/redfish/v1/Managers/${MANAGER_ID}/LogServices/Dump/Actions/LogService.CollectDiagnosticData"
# }
- [Return] ${task_dict["Payload"]["HttpHeaders"][-1].split("/")[-1]}
+ RETURN ${task_dict["Payload"]["HttpHeaders"][-1].split("/")[-1]}
Auto Generate BMC Dump
[Documentation] Auto generate BMC dump.
@@ -341,7 +341,7 @@
... /xyz/openbmc_project/dump/bmc xyz.openbmc_project.Dump.Create CreateDump a{sv} 0
${stdout} ${stderr} ${rc}=
... BMC Execute Command ${cmd}
- [Return] ${stdout} ${stderr} ${rc}
+ RETURN ${stdout} ${stderr} ${rc}
Get Dump Size
[Documentation] Get dump size.
@@ -367,7 +367,7 @@
Log ${dump_uri}
${dump_data}= Redfish.Get Properties ${dump_uri}
- [Return] ${dump_data["data"]["Size"]}
+ RETURN ${dump_data["data"]["Size"]}
Get Dump ID
[Documentation] Return dump ID.
@@ -395,7 +395,7 @@
${task_dict}= Redfish.Get Properties /redfish/v1/TaskService/Tasks/${task_id}
${key} ${value}= Set Variable ${task_dict["Payload"]["HttpHeaders"][-1].split(":")}
Run Keyword If '${key}' != 'Location' Fail
- [Return] ${value.strip('/').split('/')[-1]}
+ RETURN ${value.strip('/').split('/')[-1]}
Get Task Status
[Documentation] Return task status.
@@ -405,7 +405,7 @@
# task_id Task ID.
${resp}= Redfish.Get Properties /redfish/v1/TaskService/Tasks/${task_id}
- [Return] ${resp['TaskState']}
+ RETURN ${resp['TaskState']}
Check Task Completion
[Documentation] Check if the task is complete.
@@ -426,7 +426,7 @@
Wait Until Keyword Succeeds 10 min 15 sec Check Task Completion ${task_id}
${dump_id}= Get Dump ID ${task_id}
- [Return] ${dump_id} Completed
+ RETURN ${dump_id} Completed
Create BMC User Dump
@@ -494,7 +494,7 @@
# s "xyz.openbmc_project.Common.Progress.OperationStatus.Completed".
${status}= Set Variable ${stdout.split('.')[-1].strip('"')}
- [Return] ${status}
+ RETURN ${status}
Verify Dump Status In BMC
[Documentation] Verify Dump Status in BMC.