commit 49c1b53931191184251a4d1d9ba9ab127ee9f9fb
author Sridevi Ramesh <sridevra@in.ibm.com> Fri May 09 04:32:43 2025 -0500
committer George Keishing <gkeishin@gmail.com> Tue May 13 07:17:41 2025 +0000
tree 9363b22f9ec73a5d3c38ba36662ba818fb042605
parent 7bd7df39af96fa3c80a2868b0326e37c040fa9ff

Fix deprecrated Run Keyword If for systems

Changes:
 - Run Keyword If is deprecated since
   Robot Framework version 5.*, use IF and END or Inline IF

Tested:
 - Checked using robot dry-run to make sure the
   syntax is not broken

Change-Id: I9bd9ba2706772fb288c62fa43016eaa343fc7324
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

redfish/systems/test_sensor_monitoring.robot

diff --git a/redfish/systems/test_sensor_monitoring.robot b/redfish/systems/test_sensor_monitoring.robot
index f3a1bfe..4115804 100644
--- a/redfish/systems/test_sensor_monitoring.robot
+++ b/redfish/systems/test_sensor_monitoring.robot
@@ -93,10 +93,13 @@
     Should Not Be Empty   ${OS_HOST}
     Should Not Be Empty   ${OS_USERNAME}
     Should Not Be Empty   ${OS_PASSWORD}
-    Run Keyword If  '${OPENBMC_CONN_METHOD}' == 'ssh'
-    ...    Should Not Be Empty   ${OPENBMC_HOST}
-    ...  ELSE IF  '${OPENBMC_CONN_METHOD}' == 'telnet'
-    ...    Should Not Be Empty   ${OPENBMC_SERIAL_HOST}
+
+    IF  '${OPENBMC_CONN_METHOD}' == 'ssh'
+        Should Not Be Empty   ${OPENBMC_HOST}
+    ELSE IF  '${OPENBMC_CONN_METHOD}' == 'telnet'
+        Should Not Be Empty   ${OPENBMC_SERIAL_HOST}
+    END
+
     Should Not Be Empty   ${OPENBMC_MODEL}
 
 
@@ -158,8 +161,9 @@
         ...  or '${resp.dict['Status']['State']}' != 'Enabled'
         ...  or ${resp.dict['Reading']} == ${null}
 
-    Run Keyword If  ${condition_str}
-    ...  Append To List  ${INVALID_SENSORS}  ${sensor_name}
+    IF  ${condition_str}
+        Append To List  ${INVALID_SENSORS}  ${sensor_name}
+    END
 
 
 Check Sensor Status And Reading Via Sensor Info
@@ -179,8 +183,9 @@
         ...  or '${sensor_info['Status']['State']}' != 'Enabled'
         ...  or ${sensor_info['${reading_unit}']} == ${null}
 
-        Run Keyword If  ${condition_str}
-        ...  Append To List  ${INVALID_SENSORS}  ${sensor_info['MemberId']}
+        IF  ${condition_str}
+            Append To List  ${INVALID_SENSORS}  ${sensor_info['MemberId']}
+        END
     END
 
 
@@ -218,6 +223,7 @@
 
     FOR  ${sensor_name}  IN  @{expected_sensor_name_list}
         ${exist}=  Evaluate  '${sensor_name}' in ${curr_sensor_name_list}
-        Run Keyword If  '${exist}' == '${False}'
-        ...  Append To List  ${INVALID_SENSORS}  ${sensor_name}
+        IF  '${exist}' == '${False}'
+           Append To List  ${INVALID_SENSORS}  ${sensor_name}
+        END
     END