AC cycle test fix

Fixes the following:
  - Documentation
  - Test naming
  - Alignment
  - Added Keyword to verify PDU parameters

Resolves openbmc/openbmc-test-automation#272

Change-Id: I605de680817d4f83a2c18b65c8eb3ba6a0cc44ee
Signed-off-by: George Keishing <gkeishin@in.ibm.com>
diff --git a/extended/test_ac_cycles.robot b/extended/test_ac_cycles.robot
index aaae01e..d2fa50c 100644
--- a/extended/test_ac_cycles.robot
+++ b/extended/test_ac_cycles.robot
@@ -1,6 +1,6 @@
 *** Settings ***
 
-Documentation   This testsuite is for testing file corruption on hard power cycle
+Documentation     Test file corruption on hard power cycle.
 
 Resource          ../lib/pdu/pdu.robot
 Resource          ../lib/utils.robot
@@ -12,15 +12,26 @@
 Test Teardown     FFDC On Test Case Fail
 
 *** Test Cases ***
-Test openbmc buster
-    ${output}=  Execute Command    find /var/lib -type f |xargs -n 1 touch
+
+Test OpenBMC Buster
+    Validate Parameters
+    ${output}=  Execute Command
+    ...  find /var/lib -type f |xargs -n 1 touch
     PDU Power Cycle
-    Wait For Host To Ping   ${OPENBMC_HOST}
+    Wait For Host To Ping  ${OPENBMC_HOST}
     Sleep   1min
 
     # Need to re connect the session
     Open Connection And Log In
-    ${stdout}   ${stderr}   ${rc}=  Execute Command     echo "hello world"    return_stderr=True  return_rc=True
-    Should Be Equal As Integers    ${rc}    ${0}
+    ${stdout}   ${stderr}   ${rc}=  Execute Command  echo "hello world"
+    ...  return_stderr=True  return_rc=True
+    Should Be Equal As Integers  ${rc}    ${0}
 
 *** Keywords ***
+
+Validate Parameters
+    Should Not Be Empty  ${PDU_IP}
+    Should Not Be Empty  ${PDU_TYPE}
+    Should Not Be Empty  ${PDU_SLOT_NO}
+    Should Not Be Empty  ${PDU_USERNAME}
+    Should Not Be Empty  ${PDU_PASSWORD}