Adding valid status code on configure mac address
Changes:
- Added HTTP_INTERNAL_SERVER_ERROR status code.
Tested:
- Ran and tested on BMC Environment.
Change-Id: I59032108fd0058ee3573bbd8c9b0dda8dd753d3a
Signed-off-by: Anvesh-Kumar_Rayankula <anvesh.kumar.rayankula@ibm.com>
diff --git a/redfish/managers/test_bmc_network_mac.robot b/redfish/managers/test_bmc_network_mac.robot
index 9f9c3e0..82240e4 100644
--- a/redfish/managers/test_bmc_network_mac.robot
+++ b/redfish/managers/test_bmc_network_mac.robot
@@ -161,11 +161,11 @@
Configure MAC Settings
[Documentation] Configure MAC settings via Redfish.
- [Arguments] ${mac_address} ${valid_status_codes}=[${HTTP_OK}]
+ [Arguments] ${mac_address} ${valid_status_code}=${HTTP_OK}
# Description of argument(s):
- # mac_address MAC address of BMC.
- # expected_result Expected status of MAC configuration.
+ # mac_address MAC address of BMC.
+ # valid_status_code Expected response code, default is ${HTTP_OK}.
${active_channel_config}= Get Active Channel Config
${ethernet_interface}= Set Variable ${active_channel_config['${CHANNEL_NUMBER}']['name']}
@@ -174,7 +174,7 @@
${payload}= Create Dictionary MACAddress=${mac_address}
Redfish.Patch ${REDFISH_NW_ETH_IFACE}${ethernet_interface} body=&{payload}
- ... valid_status_codes=${valid_status_codes}
+ ... valid_status_codes=[${valid_status_code},${HTTP_INTERNAL_SERVER_ERROR}]
# After any modification on network interface, BMC restarts network
# Note: Network restart takes around 15-18s after patch request processing.
@@ -187,27 +187,27 @@
${status}= Run Keyword And Return Status
... Validate MAC On BMC ${mac_address}
- Run Keyword If ${valid_status_codes} == ${HTTP_BAD_REQUEST}
+ Run Keyword If ${valid_status_code} == ${HTTP_BAD_REQUEST}
... Should Be Equal ${status} ${False}
... msg=Allowing the configuration of an invalid MAC.
... ELSE
... Should Be Equal ${status} ${True}
... msg=Not allowing the configuration of a valid MAC.
- Verify MAC Address Via FW_Env ${mac_address} ${valid_status_codes}
+ Verify MAC Address Via FW_Env ${mac_address} ${valid_status_code}
Verify MAC Address Via FW_Env
[Documentation] Verify MAC address on FW_Env.
- [Arguments] ${mac_address} ${valid_status_codes}=[${HTTP_OK}]
+ [Arguments] ${mac_address} ${valid_status_code}=${HTTP_OK}
# Description of argument(s):
- # mac_address MAC address of BMC.
- # expected_result Expected status of MAC configuration.
+ # mac_address MAC address of BMC.
+ # valid_status_code Expected response code, default is ${HTTP_OK}.
${status}= Run Keyword And Return Status
... Validate MAC On FW_Env ${mac_address}
- Run Keyword If ${valid_status_codes} == ${HTTP_BAD_REQUEST}
+ Run Keyword If ${valid_status_code} == ${HTTP_BAD_REQUEST}
... Should Be Equal ${status} ${False}
... msg=Allowing the configuration of an invalid MAC.
... ELSE