commit 5e775733e9b5548c2925b54fa1e145cf7e1415d4
author ganesanb <ganesanb@ami.com> Tue Oct 31 11:13:20 2023 +0000
committer George Keishing <gkeishin@gmail.com> Mon Nov 06 03:30:12 2023 +0000
tree 00c34d8050c7234706b08e34a445fee8d976aeb9
parent 8bd81258551da2eb1d35163382b2f9024eeca4ca

IPMI: no_access privilege has been removed from IPMI scripts

Changes:
    - In test_ipmi_user.robot removed Test_IPMI_No_Access_Privilege_Level testcase and renamed no_access as user privilege in
Verify_Administrator_And_No_Access_Privilege_For_Different_Channels
- In test_ipmi_payload.robot removed no_access privilege

Tested:
    - Ran ipmi/test_ipmi_user.robot and ipmi/test_ipmi_payload.robot scripts Successfully

Change-Id: I604ad76c4e94df085fcada66578a047eb8c477d7
Signed-off-by: ganesanb <ganesanb@ami.com>

ipmi/test_ipmi_payload.robot

diff --git a/ipmi/test_ipmi_payload.robot b/ipmi/test_ipmi_payload.robot
index dcab815..31db911 100644
--- a/ipmi/test_ipmi_payload.robot
+++ b/ipmi/test_ipmi_payload.robot
@@ -17,7 +17,6 @@
 ${user_priv}                     2
 ${operator_priv}                 3
 ${admin_level_priv}              4
-${no_access_priv}                15
 ${new_user_passwd}               0penBmc1
 ${standard_payload_type_resp}    03 00
 ${session_setup_payload_resp}    3f 00

ipmi/test_ipmi_user.robot

diff --git a/ipmi/test_ipmi_user.robot b/ipmi/test_ipmi_user.robot
index be63b6e..32f1db3 100644
--- a/ipmi/test_ipmi_user.robot
+++ b/ipmi/test_ipmi_user.robot
@@ -22,7 +22,6 @@
 ${user_priv}            2
 ${operator_priv}        3
 ${admin_level_priv}     4
-${no_access_priv}       15
 ${valid_password}       0penBmc1
 ${max_password_length}  20
 ${ipmi_setaccess_cmd}   channel setaccess
@@ -285,17 +284,6 @@
     ${admin_level_priv}  Passed           Passed               Passed
 
 
-Test IPMI No Access Privilege Level
-    [Documentation]  Verify IPMI user with no access privilege can not run command at any level.
-    [Tags]  Test_IPMI_No_Access_Privilege_Level
-    [Template]  Test IPMI User Privilege
-    [Teardown]  Run Keywords  FFDC On Test Case Fail  AND
-    ...  Delete Created User  ${random_userid}
-
-    #Privilege level     User Cmd Status  Operator Cmd Status  Admin Cmd Status
-    ${no_access_priv}    Failed           Failed               Failed
-
-
 Enable IPMI User And Verify
     [Documentation]  Enable IPMI user and verify that the user is able
     ...  to run IPMI command.
@@ -369,9 +357,9 @@
     ...  root  ${valid_password}
 
 
-Verify Administrator And No Access Privilege For Different Channels
-    [Documentation]  Set administrator and no access privilege for different channels and verify.
-    [Tags]  Verify_Administrator_And_No_Access_Privilege_For_Different_Channels
+Verify Administrator And User Privilege For Different Channels
+    [Documentation]  Set administrator and user privilege for different channels and verify.
+    [Tags]  Verify_Administrator_And_User_Privilege_For_Different_Channels
     [Setup]  Check Active Ethernet Channels
     [Teardown]  Run Keywords  FFDC On Test Case Fail  AND
     ...  Delete Created User  ${random_userid}
@@ -384,8 +372,8 @@
     # Set admin privilege for newly created user with channel 1.
     Set Channel Access  ${random_userid}  ipmi=on privilege=${admin_level_priv}  ${CHANNEL_NUMBER}
 
-    # Set no access privilege for newly created user with channel 2.
-    Set Channel Access  ${random_userid}  ipmi=on privilege=${no_access_priv}  ${secondary_channel_number}
+    # Set user privilege for newly created user with channel 2.
+    Set Channel Access  ${random_userid}  ipmi=on privilege=${user_priv}  ${secondary_channel_number}
 
     Enable IPMI User And Verify  ${random_userid}