Fix Line is too long in test suite
+ ipmi/test_ipmi_network_verificaton.robot
W: 208, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 224, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 276, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 286, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 295, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 368, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_poh_counter.robot
W: 22, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_user.robot
W: 386, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_cold_reset.robot
W: 95, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 176, 110: Line is too long (exceeds 110 characters) (LineTooLong
+ ipmi/test_ipmi_inband_sdr.robot
W: 204, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_chassis.robot
W: 64, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 74, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_sel_time.robot
W: 7, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 9, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 13, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 15, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 186, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_systeminfo_parameters.robot
W: 98, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 109, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 154, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 175, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 211, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 293, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 313, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 421, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 422, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 441, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 442, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 498, 110: Line is too long (exceeds 110 characters) (LineTooLong)
Change-Id: I193c22c648e9fe77f017896a4ca19e35cd7adfc2
Signed-off-by: George Keishing <gkeishin@in.ibm.com>
diff --git a/ipmi/test_ipmi_chassis.robot b/ipmi/test_ipmi_chassis.robot
index 880283b..28376fe 100644
--- a/ipmi/test_ipmi_chassis.robot
+++ b/ipmi/test_ipmi_chassis.robot
@@ -61,7 +61,8 @@
Verify Chassis Power Cycle And Check Chassis Status Via IPMI
- [Documentation] Verify chassis power Cycle operation and check the Chassis Power Status using external IPMI command.
+ [Documentation] Verify chassis power Cycle operation and check the Chassis
+ ... Power Status using external IPMI command.
[Tags] Verify_Chassis_Power_Cycle_And_Check_Chassis_Status_Via_IPMI
# Chassis power cycle command via IPMI
@@ -71,7 +72,8 @@
Verify Chassis Power Reset And Check Chassis Status Via IPMI
- [Documentation] Verify chassis power Reset operation and check the Chassis Power Status using external IPMI command.
+ [Documentation] Verify chassis power Reset operation and check the Chassis
+ ... Power Status using external IPMI command.
[Tags] Verify_Chassis_Power_Reset_And_Check_Chassis_Status_Via_IPMI
# Chassis power reset command via IPMI
diff --git a/ipmi/test_ipmi_cold_reset.robot b/ipmi/test_ipmi_cold_reset.robot
index 18c4f5b..ab7bcfb 100644
--- a/ipmi/test_ipmi_cold_reset.robot
+++ b/ipmi/test_ipmi_cold_reset.robot
@@ -92,7 +92,8 @@
... Run IPMI Standard Command sensor | grep -i RPM | grep "${sensor_name}"
# Get sensor threshold readings after BMC restarts.
- ${sensor_threshold_after_reset} ${sensor_name_after_reset}= Get The Sensor Name And Threshold ${data_after_coldreset}
+ ${sensor_threshold_after_reset} ${sensor_name_after_reset}=
+ ... Get The Sensor Name And Threshold ${data_after_coldreset}
# Compare with initial sensor threshold values.
Should Be Equal ${sensor_threshold_after_reset} ${initial_sensor_threshold}
@@ -173,7 +174,8 @@
Set Sensor Threshold For given Sensor
- [Documentation] Set Sensor Threshold for given sensor with given Upper and Lower critical and non-critical values Via IPMI.
+ [Documentation] Set Sensor Threshold for given sensor with given Upper and Lower critical
+ ... and non-critical values Via IPMI.
[Arguments] ${threshold_list} ${sensor}
# Description of Argument(s):
diff --git a/ipmi/test_ipmi_inband_sdr.robot b/ipmi/test_ipmi_inband_sdr.robot
index 5619b9c..47e6ad7 100644
--- a/ipmi/test_ipmi_inband_sdr.robot
+++ b/ipmi/test_ipmi_inband_sdr.robot
@@ -201,7 +201,8 @@
Verify Reserve Device SDR Repository For Partial Record
- [Documentation] Verify whether reservation ID of Reserve Device SDR Repository is accessible to fetch partial record from Get Device SDR.
+ [Documentation] Verify whether reservation ID of Reserve Device SDR Repository is accessible
+ ... to fetch partial record from Get Device SDR.
[Tags] Verify_Reserve_Device_SDR_Repository_For_Partial_Record
# Get Reservation ID.
diff --git a/ipmi/test_ipmi_network_verificaton.robot b/ipmi/test_ipmi_network_verificaton.robot
index fd3e614..b1d4075 100644
--- a/ipmi/test_ipmi_network_verificaton.robot
+++ b/ipmi/test_ipmi_network_verificaton.robot
@@ -204,8 +204,9 @@
${Invalid_mac_address_hex}= Mac Address To Hex String ${Invalid_mac_address}
# Set MAC Address with invalid data.
- ${ipmi_set_output}= Run Inband IPMI Raw Command
- ... ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} ${CHANNEL_NUMBER} 0x05 ${Invalid_mac_address_hex} fail_on_err=0
+ ${cmd}= Catenate ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} ${CHANNEL_NUMBER}
+ ... 0x05 ${Invalid_mac_address_hex} fail_on_err=0
+ ${ipmi_set_output}= Run Inband IPMI Raw Command ${cmd}
Should Contain ${ipmi_set_output} ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][3]}
@@ -220,8 +221,9 @@
${mac_address_hex}= Mac Address To Hex String ${set_mac_address}
# Set the MAC address.
- ${ipmi_set_output}= Run Inband IPMI Raw Command
- ... ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} ${CHANNEL_NUMBER} 0x05 ${mac_address_hex} fail_on_err=0
+ ${cmd}= Catenate ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} ${CHANNEL_NUMBER}
+ ... 0x05 ${mac_address_hex} fail_on_err=0
+ ${ipmi_set_output}= Run Inband IPMI Raw Command ${cmd}
# Get the MAC address and verify.
${ipmi_output}= Run Inband IPMI Raw Command
@@ -273,7 +275,8 @@
# Set IP address source to address loaded by BIOS or system software.
${ipmi_output}= Run Keyword and Expect Error *${IPMI_RAW_CMD['LAN_Config_Params']['Set'][3]}*
- ... Run Inband IPMI Raw Command ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} 0x0${CHANNEL_NUMBER} 0x04 0x03
+ ... Run Inband IPMI Raw Command
+ ... ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} 0x0${CHANNEL_NUMBER} 0x04 0x03
Verify IP Address Source Set To Address Obtained By BMC
@@ -283,7 +286,8 @@
# Set IP address source to address obtained by BMC running other address assignment protocol
${ipmi_output}= Run Keyword and Expect Error *${IPMI_RAW_CMD['LAN_Config_Params']['Set'][3]}*
- ... Run Inband IPMI Raw Command ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} 0x0${CHANNEL_NUMBER} 0x04 0x04
+ ... Run Inband IPMI Raw Command
+ ... ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} 0x0${CHANNEL_NUMBER} 0x04 0x04
Verify IP Address Source Set To Unspecified Address Source
@@ -292,7 +296,8 @@
# Set IP address source to unspecified address source.
${ipmi_output}= Run Keyword and Expect Error *${IPMI_RAW_CMD['LAN_Config_Params']['Set'][3]}*
- ... Run Inband IPMI Raw Command ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} 0x0${CHANNEL_NUMBER} 0x04 0x00
+ ... Run Inband IPMI Raw Command
+ ... ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} 0x0${CHANNEL_NUMBER} 0x04 0x00
*** Keywords ***
@@ -364,8 +369,9 @@
${default_mac_address_hex}= Mac Address To Hex String ${set_default_mac}
# Set the Default MAC address.
- ${ipmi_set_output}= Run Inband IPMI Raw Command
- ... ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} ${CHANNEL_NUMBER} 0x05 ${default_mac_address_hex} fail_on_err=0
+ ${cmd}= Catenate ${IPMI_RAW_CMD['LAN_Config_Params']['Set'][0]} ${CHANNEL_NUMBER}
+ ... 0x05 ${default_mac_address_hex} fail_on_err=0
+ ${ipmi_set_output}= Run Inband IPMI Raw Command ${cmd}
# check whether the default MAC is set.
${ipmi_get_mac}= Run Inband IPMI Raw Command
diff --git a/ipmi/test_ipmi_poh_counter.robot b/ipmi/test_ipmi_poh_counter.robot
index 8f2ff85..ebe37a4 100644
--- a/ipmi/test_ipmi_poh_counter.robot
+++ b/ipmi/test_ipmi_poh_counter.robot
@@ -2,7 +2,8 @@
Documentation This suite tests IPMI POH Counter Support in OpenBMC.
... Feature: IPMI POH Counter Support
...
-... POH (Power-On Hours) counter is the incremental count of power ON hours in the system.
+... POH (Power-On Hours) counter is the incremental count of power ON
+... hours in the system.
...
... Request and Response data defined under data/ipmi_raw_cmd_table.py
...
@@ -17,9 +18,11 @@
...
... Minutes per count usually 60 minutes.
...
-... Wait Time given - 1 hour, 1 hour 30minutes when Host power OFF, 1 hour after Host Power ON
+... Wait Time given - 1 hour, 1 hour 30minutes when Host power OFF, 1 hour
+... after Host Power ON
...
-... Comparison between Initial POH Counter reading and reading after wait time / Power operation.
+... Comparison between Initial POH Counter reading and reading after wait
+... time / Power operation.
Library Collections
diff --git a/ipmi/test_ipmi_sel_time.robot b/ipmi/test_ipmi_sel_time.robot
index 694168a..028659a 100644
--- a/ipmi/test_ipmi_sel_time.robot
+++ b/ipmi/test_ipmi_sel_time.robot
@@ -1,18 +1,24 @@
*** Settings ***
Documentation Module to test IPMI SEL Time functionality.
-... Pre-requisite Condition : Client Machine and BMC should be in Same TimeZone (example : UST)
+... Pre-requisite Condition : Client Machine and BMC should be in
+... Same TimeZone (example : UST)
...
-... IPMI Raw command variables are defined under ../data/ipmi_raw_command_table.py
-... Python basic functionalities are defined under ../lib/functions.py imported under ../lib/resource.robot
+... IPMI Raw command variables are defined under
+... ../data/ipmi_raw_command_table.py
+... Python basic functionalities are defined under
+... ../lib/functions.py imported under ../lib/resource.robot
...
-... Test the Set/Get SEL Time functionality and compare the result against BMC Native command (date).
+... Test the Set/Get SEL Time functionality and compare the result against
+... BMC Native command (date).
...
... Set the Time Sync Mode from NTP to Manual to Set SEL Time.
... Time Sync Mode change performed via REDFISH URI.
-... Performs the change in Time Sync Mode with Test Setup and Teardown Execution with default NETWORK_TIMEOUT provided under ../lib/resource.robot.
+... Performs the change in Time Sync Mode with Test Setup and Teardown Execution
+... with default NETWORK_TIMEOUT provided under ../lib/resource.robot.
...
-... NETWORK_RESTART_TIME added for Set SEL Time and Add SEL Entry as the corresponding command takes approx 5 seconds for the operation to reflect.
+... NETWORK_RESTART_TIME added for Set SEL Time and Add SEL Entry as the corresponding
+... command takes approx 5 seconds for the operation to reflect.
...
... Current SEL time identified via BMC Native command (date) and perform SEL Time operations.
...
@@ -183,7 +189,8 @@
${sel_date_raw}= Evaluate " ".join(${sel_date_raw})
# Set incomplete SEL Time with one less request byte.
- ${Set_seltime_incomplete}= Run Keyword and Expect Error *${IPMI_RAW_CMD['SEL_entry']['Set_SEL_Time'][4]}*
+ ${Set_seltime_incomplete}=
+ ... Run Keyword and Expect Error *${IPMI_RAW_CMD['SEL_entry']['Set_SEL_Time'][4]}*
... Run IPMI Command ${IPMI_RAW_CMD['SEL_entry']['Set_SEL_Time'][0]} ${sel_date_raw}
Should Contain ${Set_seltime_incomplete} ${IPMI_RAW_CMD['SEL_entry']['Set_SEL_Time'][3]}
diff --git a/ipmi/test_ipmi_systeminfo_parameters.robot b/ipmi/test_ipmi_systeminfo_parameters.robot
index f50ed3d..89b6d49 100644
--- a/ipmi/test_ipmi_systeminfo_parameters.robot
+++ b/ipmi/test_ipmi_systeminfo_parameters.robot
@@ -95,7 +95,8 @@
... and expect to get the error message for invalid length.
[Tags] Verify_Get_System_Info_Set_In_Progress_With_Invalid_Data_Length
- # Check if the Get System Info Parameter for param 0 - set in progress throws error for invalid data length.
+ # Check if the Get System Info Parameter for param 0 - set in progress throws
+ # error for invalid data length.
Run Keyword and Expect Error *${IPMI_RAW_CMD['System_Info']['param0_Set_In_Progress']['Get'][1]}*
... Run IPMI Standard Command
... raw ${IPMI_RAW_CMD['System_Info']['param0_Set_In_Progress']['Get'][0]} 0x00
@@ -106,7 +107,8 @@
... and expect to get the error message for invalid length.
[Tags] Verify_Set_System_Info_Set_In_Progress_With_Invalid_Data_Length
- # Check if the Set System Info Parameter for param 0 - set in progress throws error for invalid data length.
+ # Check if the Set System Info Parameter for param 0 - set in progress throws
+ # error for invalid data length.
Run Keyword and Expect Error *${IPMI_RAW_CMD['System_Info']['param0_Set_In_Progress']['Set'][1]}*
... Run IPMI Standard Command
... raw ${IPMI_RAW_CMD['System_Info']['param0_Set_In_Progress']['Set'][0]} 0x00 0x00
@@ -151,7 +153,8 @@
... and expect to get the error message for invalid length.
[Tags] Verify_Get_System_Info_System_Firmware_Version_With_Invalid_Data_Length
- # Check if the Get System Info Parameter for param 1 - System Firmware Version throws error for invalid data length.
+ # Check if the Get System Info Parameter for param 1 - System Firmware Version throws
+ # error for invalid data length.
Run Keyword and Expect Error *${IPMI_RAW_CMD['System_Info']['param1_System_Firmware_Version']['Get'][1]}*
... Run IPMI Standard Command
... raw ${IPMI_RAW_CMD['System_Info']['param1_System_Firmware_Version']['Get'][0]} 0x00
@@ -172,7 +175,8 @@
${firmware_version} ${fw_hex_data}= Identify Request Data ${firmware_version}
# Consider random string generated is 'zwclMXwfczMvcYz'.
# The request data bytes will be 15 bytes, in which 14 bytes are only expected.
- # Check if the Set System Info Parameter for param 1 - System Firmware Version throws error for invalid request data.
+ # Check if the Set System Info Parameter for param 1 - System Firmware Version throws
+ # error for invalid request data.
Run Keyword and Expect Error *${IPMI_RAW_CMD['System_Info']['param1_System_Firmware_Version']['Set'][1]}*
... Run IPMI Standard Command
... raw ${IPMI_RAW_CMD['System_Info']['param1_System_Firmware_Version']['Set'][0]} ${firmware_version}
@@ -208,7 +212,8 @@
... and expect to get the error message for invalid length.
[Tags] Verify_Get_System_Info_System_Name_With_Invalid_Data_Length
- # Check if the Get System Info Parameter for param 2 - System Name throws error for invalid request data length.
+ # Check if the Get System Info Parameter for param 2 - System Name throws error
+ # for invalid request data length.
Run Keyword and Expect Error *${IPMI_RAW_CMD['System_Info']['param2_System_Name']['Get'][1]}*
... Run IPMI Standard Command
... raw ${IPMI_RAW_CMD['System_Info']['param2_System_Name']['Get'][0]} 0x00
@@ -290,7 +295,8 @@
... and expect to get the error message for invalid length.
[Tags] Verify_Get_System_Info_Primary_OS_Name_With_Invalid_Data_Length
- # Check if the Get System Info Parameter for param 3 - Primary OS Name throws error for invalid request data.
+ # Check if the Get System Info Parameter for param 3 - Primary OS Name throws
+ # error for invalid request data.
Run Keyword and Expect Error *${IPMI_RAW_CMD['System_Info']['param3_Primary_OS_Name']['Get'][1]}*
... Run IPMI Standard Command
... raw ${IPMI_RAW_CMD['System_Info']['param3_Primary_OS_Name']['Get'][0]} 0x00
@@ -310,7 +316,8 @@
# Here 15 bytes so, data 17 - extra byte.
${os_name} ${name_hex_data}= Identify Request Data ${invalid_os_version}
- # Check if the Set System Info Parameter for param 3 - Primary OS Name throws error for invalid data request.
+ # Check if the Set System Info Parameter for param 3 - Primary OS Name throws error
+ # for invalid data request.
Run Keyword and Expect Error *${IPMI_RAW_CMD['System_Info']['param3_Primary_OS_Name']['Set'][1]}*
... Run IPMI Standard Command
... raw ${IPMI_RAW_CMD['System_Info']['param3_Primary_OS_Name']['Set'][0]} ${os_name}
@@ -418,8 +425,10 @@
... with extra bytes, and expect to get the error message for invalid length.
[Tags] Verify_Get_System_Info_Present_OS_Version_Number_With_Invalid_Data_Length
- # Check if the Get System Info Parameter for param 5 - Present OS Version Number throws error for invalid request data.
- Run Keyword and Expect Error *${IPMI_RAW_CMD['System_Info']['param5_Present_OS_Version_number']['Get'][1]}*
+ # Check if the Get System Info Parameter for param 5 - Present OS Version Number throws
+ # error for invalid request data.
+ Run Keyword and Expect Error
+ ... *${IPMI_RAW_CMD['System_Info']['param5_Present_OS_Version_number']['Get'][1]}*
... Run IPMI Standard Command
... raw ${IPMI_RAW_CMD['System_Info']['param5_Present_OS_Version_number']['Get'][0]} 0x00
@@ -438,8 +447,10 @@
# Here 15 bytes so, data 17 - extra byte.
${os_name} ${name_hex_data}= Identify Request Data ${invalid_os_version}
- # Check if the Set System Info Parameter for param 5 - Present OS Version Number throws error for invalid request data.
- Run Keyword and Expect Error *${IPMI_RAW_CMD['System_Info']['param5_Present_OS_Version_number']['Set'][1]}*
+ # Check if the Set System Info Parameter for param 5 - Present OS Version Number throws
+ # error for invalid request data.
+ Run Keyword and Expect Error
+ ... *${IPMI_RAW_CMD['System_Info']['param5_Present_OS_Version_number']['Set'][1]}*
... Run IPMI Standard Command
... raw ${IPMI_RAW_CMD['System_Info']['param5_Present_OS_Version_number']['Set'][0]} ${os_name}
@@ -495,7 +506,8 @@
Get System Firmware Version
- [Documentation] Run Get system info parameter command for system firmware version and return response data.
+ [Documentation] Run Get system info parameter command for system firmware version
+ ... and return response data.
# Get System Info Parameter for param 1 - System Firmware Version.
${resp}= Run IPMI Standard Command
diff --git a/ipmi/test_ipmi_user.robot b/ipmi/test_ipmi_user.robot
index 4df791a..7cccf29 100644
--- a/ipmi/test_ipmi_user.robot
+++ b/ipmi/test_ipmi_user.robot
@@ -383,7 +383,8 @@
Verify IPMI Command ${random_username} ${valid_password} Administrator ${CHANNEL_NUMBER}
# Verify that user is unable to run IPMI command with channel 2.
- Run IPMI Standard Command sel info ${secondary_channel_number} expected_rc=${1} U=${random_username} P=${valid_password}
+ Run IPMI Standard Command
+ ... sel info ${secondary_channel_number} expected_rc=${1} U=${random_username} P=${valid_password}
Verify Operator And User Privilege For Different Channels