commit 7981f4323a16aa9fc676f8eb1ddcc48cf2854653
author George Keishing <gkeishin@in.ibm.com> Wed Nov 15 23:49:16 2023 +0530
committer George Keishing <gkeishin@gmail.com> Mon Nov 20 06:03:17 2023 +0000
tree 19fd4fbdcec696abd65a47af4579abc665241f38
parent f76c740f12aac74d53003938569585e913101cc3

Consolidate username and password in test

Changes:
    - Remove REST_USERNAME and REST_PASSWORD. Legacy username
      and password, default user OPENBMC_USERNAME and
      OPENBMC_PASSWORD.

Tested:
    - Boot test and sanity runs from sandbox

Change-Id: I86955d512530889c1a875b5efcc71f9df99432d9
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

lib/resource.robot

diff --git a/lib/resource.robot b/lib/resource.robot
index 711f8e5..44012a7 100755
--- a/lib/resource.robot
+++ b/lib/resource.robot
@@ -28,8 +28,6 @@
 ${AUTH_URI}       https://${OPENBMC_HOST}${AUTH_SUFFIX}
 ${OPENBMC_USERNAME}    root
 ${OPENBMC_PASSWORD}    0penBmc
-${REST_USERNAME}       root
-${REST_PASSWORD}       0penBmc
 ${OPENBMC_ADMIN_USERNAME}  admin
 ${OPENBMC_ADMIN_PASSWORD}  ${EMPTY}
 ${SERVICE_USER_PASSWORD}   ${EMPTY}

lib/rest_client.robot

diff --git a/lib/rest_client.robot b/lib/rest_client.robot
index 2ebbd14..8d5792e 100644
--- a/lib/rest_client.robot
+++ b/lib/rest_client.robot
@@ -131,8 +131,8 @@
 Initialize OpenBMC
     [Documentation]  Do a REST login connection within specified time.
     [Arguments]  ${timeout}=20  ${quiet}=${1}
-    ...  ${rest_username}=${REST_USERNAME}
-    ...  ${rest_password}=${REST_PASSWORD}
+    ...  ${rest_username}=${OPENBMC_USERNAME}
+    ...  ${rest_password}=${OPENBMC_PASSWORD}
 
     # Description of argument(s):
     # timeout        REST login attempt time out.
@@ -153,8 +153,8 @@
 
 BMC Web Login Request
     [Documentation]  Do BMC web-based login.
-    [Arguments]  ${timeout}=20  ${rest_username}=${REST_USERNAME}
-    ...  ${rest_password}=${REST_PASSWORD}
+    [Arguments]  ${timeout}=20  ${rest_username}=${OPENBMC_USERNAME}
+    ...  ${rest_password}=${OPENBMC_PASSWORD}
 
     # Description of argument(s):
     # timeout        REST login attempt time out.
@@ -182,8 +182,8 @@
 Post Login Request
     [Documentation]  Do REST login request.
     [Arguments]  ${timeout}=20  ${quiet}=${1}
-    ...  ${rest_username}=${REST_USERNAME}
-    ...  ${rest_password}=${REST_PASSWORD}
+    ...  ${rest_username}=${OPENBMC_USERNAME}
+    ...  ${rest_password}=${OPENBMC_PASSWORD}
 
     # Description of argument(s):
     # timeout        REST login attempt time out.
@@ -377,8 +377,8 @@
 
 Redfish Login
     [Documentation]  Do BMC web-based login.
-    [Arguments]  ${timeout}=20  ${rest_username}=${REST_USERNAME}
-    ...  ${rest_password}=${REST_PASSWORD}  ${kwargs}=${EMPTY}
+    [Arguments]  ${timeout}=20  ${rest_username}=${OPENBMC_USERNAME}
+    ...  ${rest_password}=${OPENBMC_PASSWORD}  ${kwargs}=${EMPTY}
 
     # Description of argument(s):
     # timeout        REST login attempt time out.