commit 81be58b1a8f0da99804c9fed48556efbf7c10c65
author George Keishing <gkeishin@in.ibm.com> Fri Feb 10 00:59:29 2023 -0600
committer George Keishing <gkeishin@in.ibm.com> Fri Feb 10 01:01:22 2023 -0600
tree 87e684e554008cf47fad13e3c6a46afcd6293101
parent fdd2dcfef2e94c0c0cc8faf304db775d72e8f293

Pylint error and warning fixes

Changes:
     - C0114 Missing module docstring
     - C0103 Constant name "OS_BOOT_CBoot" doesn't conform
       to UPPER_CASE naming style
     - C0103 Constant name "OS_BOOT_DiagBoot" doesn't conform
       to UPPER_CASE naming style

Tested:
    - python3 -m pylint data/variables.py

Change-Id: I7945c31dd25dead2fb39f416eae0c34ae20b3dfb
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

data/variables.py

diff --git a/data/variables.py b/data/variables.py
index 55d513f..286ae17 100755
--- a/data/variables.py
+++ b/data/variables.py
@@ -1,3 +1,9 @@
+#!/usr/bin/env python3
+
+r"""
+Variable constants applicable to all OpenBMC test.
+"""
+
 import os
 
 from robot.libraries.BuiltIn import BuiltIn
@@ -140,8 +146,8 @@
 OS_BOOT_CDROM = STATE_DBUS_BASE + "OperatingSystem.Status.OSStatus.CDROMBoot"
 OS_BOOT_ROM = STATE_DBUS_BASE + "OperatingSystem.Status.OSStatus.ROMBoot"
 OS_BOOT_PXE = STATE_DBUS_BASE + "OperatingSystem.Status.OSStatus.PXEBoot"
-OS_BOOT_CBoot = STATE_DBUS_BASE + "OperatingSystem.Status.OSStatus.CBoot"
-OS_BOOT_DiagBoot = STATE_DBUS_BASE + "OperatingSystem.Status.OSStatus.DiagBoot"
+OS_BOOT_CBOOT = STATE_DBUS_BASE + "OperatingSystem.Status.OSStatus.CBoot"
+OS_BOOT_DIAGBOOT = STATE_DBUS_BASE + "OperatingSystem.Status.OSStatus.DiagBoot"
 
 # Boot variables.
 BOOT_SOURCE_DEFAULT = "xyz.openbmc_project.Control.Boot.Source.Sources.Default"

tests/ipmi/test_sensors_ipmi.robot

diff --git a/tests/ipmi/test_sensors_ipmi.robot b/tests/ipmi/test_sensors_ipmi.robot
index 7880922..e524335 100644
--- a/tests/ipmi/test_sensors_ipmi.robot
+++ b/tests/ipmi/test_sensors_ipmi.robot
@@ -138,7 +138,7 @@
     [Template]  Check OperatingSystemState
 
     # OperatingSystemStateID  OperatingSystemState
-    0x02                      ${OS_BOOT_CBoot}
+    0x02                      ${OS_BOOT_CBOOT}
 
 
 Set OperatingSystemState To PXEBoot And Verify
@@ -188,7 +188,7 @@
     [Template]  Check OperatingSystemState
 
     # OperatingSystemStateID  OperatingSystemState
-    0x08                      ${OS_BOOT_DiagBoot}
+    0x08                      ${OS_BOOT_DIAGBOOT}
 
 
 # Boot Progress Test Cases.