Code clean-up drive as per latest robot 7.x
Changes:
- Keyword name 'Should contain' does not follow
case convention
- Section '*** Variables ***' is empty
- Section variable '${poweron_flag}' name is
not uppercase
- Invalid number of empty lines between sections
Tested:
- NA
Change-Id: I424640ffc0ceba82f1f13b57ae7df60e9118546f
Signed-off-by: George Keishing <gkeishin@in.ibm.com>
diff --git a/xcat/test_xcat_group.robot b/xcat/test_xcat_group.robot
index 1a553d7..34e6496 100644
--- a/xcat/test_xcat_group.robot
+++ b/xcat/test_xcat_group.robot
@@ -12,8 +12,8 @@
*** Variables ***
-${poweron_flag} ON
-${poweroff_flag} OFF
+${POWERON_FLAG} ON
+${POWEROFF_FLAG} OFF
${NUM_POWER_STATUS_CHECKS} 1000
*** Test Cases ***
@@ -28,7 +28,6 @@
Validate Added Node ${bmc}
END
-
Power On Via XCAT And Validate
[Documentation] Power on via XCAT and validate.
[Tags] Power_On_Via_XCAT_And_Validate
@@ -36,10 +35,9 @@
# Power on each BMC node and validate the power status.
FOR ${bmc} IN @{BMC_LIST}
Power On Via XCAT ${bmc}
- Validate Power Status Via XCAT ${bmc} ${poweron_flag}
+ Validate Power Status Via XCAT ${bmc} ${POWERON_FLAG}
END
-
Power Off Via XCAT And Validate
[Documentation] Power off via XCAT and validate.
[Tags] Power_Off_Via_XCAT_And_Validate
@@ -47,10 +45,9 @@
# Power off each BMC node and validate the power status.
FOR ${bmc} IN @{BMC_LIST}
Power Off Via XCAT ${bmc}
- Validate Power Status Via XCAT ${bmc} ${poweroff_flag}
+ Validate Power Status Via XCAT ${bmc} ${POWEROFF_FLAG}
END
-
Add Nodes To Group List
[Documentation] Add BMC nodes into group.
[Tags] Add_Nodes_To_Group_List
@@ -61,7 +58,6 @@
Validate Node Added In Group ${bmc} ${GROUP}
END
-
Power On Group And Validate
[Documentation] Power on all BMCs in group and validate.
[Tags] Power_On_Group_And_Validate
@@ -81,10 +77,9 @@
# Validate power status on each BMC node one by one.
FOR ${bmc_node} IN @{bmc_nodes}
- Validate Power Status Via XCAT ${bmc_node} ${poweron_flag}
+ Validate Power Status Via XCAT ${bmc_node} ${POWERON_FLAG}
END
-
Power Off Group And Validate
[Documentation] Power off all BMCs in group and validate.
[Tags] Power_Off_Group_And_Validate
@@ -103,10 +98,9 @@
# Validate power status on each BMC node one by one.
FOR ${bmc_node} IN @{bmc_nodes}
- Validate Power Status Via XCAT ${bmc_node} ${poweroff_flag}
+ Validate Power Status Via XCAT ${bmc_node} ${POWEROFF_FLAG}
END
-
Continuous Node Power Status
[Documentation] Continuously get the power status.
# This keyword verifies the REST connectivity between XCAT and the BMC node.
@@ -122,10 +116,9 @@
# of the BMC node
FOR ${index} IN RANGE 1 ${NUM_POWER_STATUS_CHECKS}
- Validate Power Status Via XCAT ${BMC_LIST[1]} ${poweron_flag}
+ Validate Power Status Via XCAT ${BMC_LIST[1]} ${POWERON_FLAG}
END
-
Get Temperature Reading Via XCAT
[Documentation] Get temperature reading via XCAT.
[Tags] Get_Temperature_Reading_Via_XCAT
@@ -149,7 +142,6 @@
Log \n Temperature reading on $[bmc}\n ${temp_reading}
END
-
Get Fanspeed Reading Via XCAT
[Documentation] Get fanspeed via XCAT.
[Tags] Get_Fanspeed_Reading_Via_XCAT
@@ -168,7 +160,6 @@
Log \n fanspeed on $[bmc}\n ${fanspeed}
END
-
Get Voltage Reading Via XCAT
[Documentation] Get voltage via XCAT.
[Tags] Get_Voltage_Reading_Via_XCAT
@@ -184,7 +175,6 @@
Log \n Voltage reading on $[bmc}\n ${voltage}
END
-
Get Wattage Via XCAT
[Documentation] Get wattage via XCAT.
[Tags] Get_Wattage_Via_XCAT