commit 8bd280d377930113061314ca18769d89a127ec67
author Sridevi Ramesh <sridevra@in.ibm.com> Sun Sep 21 07:03:43 2025 -0500
committer George Keishing <gkeishin@gmail.com> Wed Sep 24 09:46:51 2025 +0000
tree 50738aeeb3a8f17265647ff56f18adb7e05755ce
parent 2f3fbb500f8ca094a6ddfed6aa792ffea6500963

IPMI test suite with latest directives

Changes:
   - Run KeyWord If is deprecated since Robot
     Framework version 5.*, use 'IF' instead

Tested:
   - Checked using robot dry-run to make sure the
     syntax is not broken

Change-Id: Id248062c860ff209875d8f57315f572d9321f783
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

lib/list_utils.robot

diff --git a/lib/list_utils.robot b/lib/list_utils.robot
index ae477ef..ebdef6f 100644
--- a/lib/list_utils.robot
+++ b/lib/list_utils.robot
@@ -1,8 +1,10 @@
 *** Settings ***
 Documentation  This module contains keywords for list manipulation.
+
 Library  Collections
 
 *** Keywords ***
+
 Smart Combine Lists
     [Documentation]  Combine all valid list arguments and return the result.
     [Arguments]  @{lists}
@@ -16,8 +18,10 @@
 
     FOR  ${arg}  IN  @{lists}
       ${type_arg}=  Evaluate  str(type($lists[${index}])).split("'")[1]
-      Run Keyword If  '${type_arg}' != 'list'  Run Keywords  Remove From List  ${lists}  ${index}  AND
-      ...  Continue For Loop
+      IF  '${type_arg}' != 'list'
+           Remove From List  ${lists}  ${index}
+           Continue For Loop
+      END
       ${index}=  Evaluate  ${index}+1
     END
 
@@ -31,6 +35,7 @@
     ...  values common to both lists with no duplicates.
     [Arguments]  ${list1}  ${list2}
 
+    # Description of argument(s):
     # list1      The first list to intersect.
     # list2      The second list to intersect.
 
@@ -46,7 +51,7 @@
 
     FOR  ${element}  IN  @{larger_list}
       ${rc}=  Run Keyword and Return Status  List Should Contain Value  ${smaller_list}  ${element}
-      Run Keyword If  '${rc}' == 'True'  Append to List  ${intersected_list}  ${element}
+      IF  '${rc}' == 'True'  Append to List  ${intersected_list}  ${element}
     END
 
     @{intersected_list}=  Remove Duplicates  ${intersected_list}
@@ -67,8 +72,7 @@
     FOR  ${item}  IN  @{list1}
         ${status}=  Run Keyword And Return Status
         ...  Should Contain  ${list2}  ${item}
-        Run Keyword If  '${status}' == '${False}'
-        ...  Append To List  ${diff_list}  ${item}
+        IF  '${status}' == '${False}'  Append To List  ${diff_list}  ${item}
     END
 
     RETURN  ${diff_list}