Pylint warning and errors clean up
Changes:
- C0301: Line too long
- R1705: Unnecessary "elif" after "return", remove
the leading "el" from "elif"
- R1710: Either all return statements in a function
should return an expression, or none of them should.
- Remove documentation no longer needed
Tested:
- NA
Change-Id: Ib2bc72b62655bbdd86dd63a349e5da558b222a76
Signed-off-by: George Keishing <gkeishin@in.ibm.com>
diff --git a/lib/pldm_utils.py b/lib/pldm_utils.py
index 81e53fe..f2541f9 100755
--- a/lib/pldm_utils.py
+++ b/lib/pldm_utils.py
@@ -31,14 +31,17 @@
}
Description of argument(s):
- option_string A string of options which are to be processed by the pldmtool command.
- parse_results Parse the pldmtool results and return a dictionary rather than the raw
- pldmtool output.
- bsu_options Options to be passed directly to bmc_execute_command. See its prolog for
- details.
+ option_string A string of options which are to be processed by the
+ pldmtool command.
+ parse_results Parse the pldmtool results and return a dictionary
+ rather than the raw
+ pldmtool output.
+ bsu_options Options to be passed directly to bmc_execute_command.
+ See its prolog for details.
"""
- # This allows callers to specify arguments in python style (e.g. print_out=1 vs. print_out=${1}).
+ # This allows callers to specify arguments in python style
+ # (e.g. print_out=1 vs. print_out=${1}).
bsu_options = fa.args_to_objects(bsu_options)
stdout, stderr, rc = bsu.bmc_execute_command(
@@ -133,9 +136,11 @@
if attr_type == "BIOSInteger":
return attr_val_int_dict
- elif attr_type == "BIOSString":
+ if attr_type == "BIOSString":
return attr_val_str_dict
+ return None
+
def GetRandomBIOSIntAndStrValues(attr_name, count):
"""
@@ -276,7 +281,6 @@
except ValueError:
try:
# The data values have a double quote in them.
- # Eg: '"IBM I"' instead of just 'IBM I'
data = '"' + str(existing_data[attr]) + '"'
temp_list[attr].remove(data)
except ValueError: