Changing the in-band test cases to external.

Resolves openbmc/openbmc-test-automation#1265

Change-Id: I788b19646ac43ffa6a8b4c91d73118ebdcfdc945
Signed-off-by: Sweta Potthuri <spotthur@in.ibm.com>
diff --git a/tests/ipmi/test_general_ipmi.robot b/tests/ipmi/test_general_ipmi.robot
index 821eaba..c1f5287 100644
--- a/tests/ipmi/test_general_ipmi.robot
+++ b/tests/ipmi/test_general_ipmi.robot
@@ -8,7 +8,6 @@
 Resource            ../../lib/bmc_network_utils.robot
 Variables           ../data/ipmi_raw_cmd_table.py
 
-Suite Setup         Suite Setup Execution
 Test Teardown       FFDC On Test Case Fail
 
 
@@ -548,37 +547,6 @@
     ...  data=${value_dict}
 
 
-Log LAN Print Details
-    [Documentation]  Log IPMI LAN print details and return them as a string.
-
-    # Example:
-
-    # Set in Progress        : Set Complete
-    # Auth Type Support      : MD5
-    # Auth Type Enable       : Callback : MD5
-    #                        : User     : MD5
-    #                        : Operator : MD5
-    #                        : Admin    : MD5
-    #                        : OEM      : MD5
-    # IP Address Source      : Static Address
-    # IP Address             : xx.xx.xx.xx
-    # Subnet Mask            : yy.yy.yy.yy
-    # MAC Address            : xx.xx.xx.xx.xx.xx
-    # Default Gateway IP     : xx.xx.xx.xx
-    # 802.1q VLAN ID         : Disabled Cipher Suite
-    # Priv Max               : Not Available
-    # Bad Password Threshold : Not Available
-
-    Login To OS Host
-    Check If IPMI Tool Exist
-
-    ${cmd_buf}=  Catenate  ${IPMI_INBAND_CMD}  lan print
-
-    ${stdout}  ${stderr}  ${rc}=  OS Execute Command  ${cmd_buf}
-    Log  ${stdout}
-    [Return]  ${stdout}
-
-
 Fetch Details From LAN Print
     [Documentation]  Fetch details from LAN print.
     [Arguments]  ${field_name}
@@ -587,22 +555,8 @@
     # ${field_name}   Field name to be fetched from LAN print
     #                 (e.g. "MAC Address", "Source").
 
-    ${stdout}=  Log LAN Print Details
+    ${stdout}=  Run External IPMI Standard Command  lan print
     ${fetch_value}=  Get Lines Containing String  ${stdout}  ${field_name}
     ${value_fetch}=  Fetch From Right  ${fetch_value}  :${SPACE}
     [Return]  ${value_fetch}
 
-
-Suite Setup Execution
-    [Documentation]  Do the suite setup execution tasks.
-
-    Should Not Be Empty
-    ...  ${OS_HOST}  msg=You must provide DNS name/IP of the OS host.
-    Should Not Be Empty
-    ...  ${OS_USERNAME}  msg=You must provide OS host user name.
-    Should Not Be Empty
-    ...  ${OS_PASSWORD}  msg=You must provide OS host user password.
-
-    # Boot To OS
-    REST Power On  quiet=${1}
-