commit c9649ca1315d464f2e7620c7aed0d362fa406a5e
author Sweta Potthuri <spotthur@in.ibm.com> Wed May 07 00:48:43 2025 -0500
committer George Keishing <gkeishin@gmail.com> Fri May 09 10:33:24 2025 +0000
tree 0b52de3d01772b2b1eb5b7eef74e63aaaf80e1fc
parent b616379931aad9f30aec3a8eac2279aa8f49f0b5

Network Fix: Change the HTTP return keyword

Changes:
    - Fix for Delete IP address keyword

Tested:
    - Ran and tested on BMC Environment

Change-Id: I18ed9ab59cb3d59e2c21e770a29af6248fbf615c
Signed-off-by: Sweta Potthuri <spotthur@in.ibm.com>

lib/bmc_network_utils.robot

diff --git a/lib/bmc_network_utils.robot b/lib/bmc_network_utils.robot
index 68cf19b..cf66d19 100644
--- a/lib/bmc_network_utils.robot
+++ b/lib/bmc_network_utils.robot
@@ -526,7 +526,7 @@
 
 Delete IP Address
     [Documentation]  Delete IP Address Of BMC.
-    [Arguments]  ${ip}  ${valid_status_codes}=${HTTP_OK}
+    [Arguments]  ${ip}  ${valid_status_codes}=[${HTTP_OK},${HTTP_ACCEPTED},${HTTP_NO_CONTENT}]
 
     # Description of argument(s):
     # ip                  IP address to be deleted (e.g. "10.7.7.7").
@@ -555,16 +555,18 @@
     ${ethernet_interface}=  Set Variable  ${active_channel_config['${CHANNEL_NUMBER}']['name']}
 
     Redfish.patch  ${REDFISH_NW_ETH_IFACE}${ethernet_interface}  body=&{data}
-    ...  valid_status_codes=[${valid_status_codes}]
+    ...  valid_status_codes=${valid_status_codes}
 
     # Note: Network restart takes around 15-18s after patch request processing
     Sleep  ${NETWORK_TIMEOUT}s
     Wait For Host To Ping  ${OPENBMC_HOST}  ${NETWORK_TIMEOUT}
 
     ${delete_status}=  Run Keyword And Return Status  Verify IP On BMC  ${ip}
-    Run Keyword If  '${valid_status_codes}' == '${HTTP_OK}'
-    ...  Should Be True  '${delete_status}' == '${False}'
-    ...  ELSE  Should Be True  '${delete_status}' == '${True}'
+    IF  '${valid_status_codes}' == '[${HTTP_OK},${HTTP_ACCEPTED},${HTTP_NO_CONTENT}]'
+        Should Be True  '${delete_status}' == '${False}'
+    ELSE
+        Should Be True  '${delete_status}' == '${True}'
+    END
 
     Validate Network Config On BMC