REST reboot cycle test

We are hitting Dbus exceptions errors frequently post reboot. We
already have PDU/AC cycle test in place. With this it will support
REST reboot cycle.

We already hit one bug with REST reboot openbmc/openbmc#1070.

These changes address the following:
  - Added REST reboot using new interface xyz
  - Documentation
  - Spacing and other guideline fixes

Resolves openbmc/openbmc-test-automation#317

Change-Id: Ia6e287aa8ffc2c37b47abfce103e79aa71bc6de1
Signed-off-by: George Keishing <gkeishin@in.ibm.com>
diff --git a/extended/test_powercycle_loop.robot b/extended/test_powercycle_loop.robot
index 37b991c..6caefe4 100644
--- a/extended/test_powercycle_loop.robot
+++ b/extended/test_powercycle_loop.robot
@@ -6,8 +6,8 @@
 Resource        ../lib/pdu/pdu.robot
 Resource        ../lib/utils.robot
 Resource        ../lib/openbmc_ffdc.robot
+Resource        ../lib/state_manager.robot
 
-Test Setup      Validate Parameters
 Test Teardown   Test Exit Logs
 
 *** Variables ***
@@ -15,26 +15,43 @@
 
 *** Test Cases ***
 
-Test Power Cycle
-    [Documentation]   By default run test for 50 loops, else user
-    ...               input iteration. Fails immediately if any
-    ...               of the execution rounds fail and checks if
-    ...               BMC is still pinging and FFDC is collected.
+Run Multiple Power Cycle
+    [Documentation]  Execute multiple power cycles.
+    [Setup]  Validate Parameters
+    [Tags]  Run_Multiple_Power_Cycle
 
-    Repeat Keyword    ${LOOP_COUNT} times   BMC Power cycle
+    # By default run test for 50 loops, else user input iteration.
+    # Fails immediately if any of the execution rounds fail and
+    # check if BMC is still pinging and FFDC is collected.
+    Repeat Keyword  ${LOOP_COUNT} times  Power Cycle System Via PDU
+
+
+Run Multiple Reboot
+    [Documentation]  Execute multiple reboots.
+    [Tags]  Run_Multiple_Reboot
+
+    # By default run test for 50 loops, else user input iteration.
+    # Fails immediately if any of the execution rounds fail and
+    # check if BMC is still pinging and FFDC is collected.
+    Repeat Keyword  ${LOOP_COUNT} times  BMC Reboot Cycle
 
 
 *** Keywords ***
 
-BMC Power cycle
-    [Documentation]    Power cycle and wait for BMC to come
-    ...                online to BMC_READY state.
-    Log   "Doing power cycle"
+Power Cycle System Via PDU
+    [Documentation]  Power cycle system and wait for BMC to reach Ready state.
+    Log  "Doing power cycle"
     PDU Power Cycle
-    Check If BMC is Up   5 min    10 sec
+    Check If BMC Is Up  5 min  10 sec
 
-    Wait Until Keyword Succeeds
-    ...    10 min   10 sec   Verify BMC State   BMC_READY
+    Wait Until Keyword Succeeds  10 min  10 sec  Is BMC Ready
+
+
+BMC Reboot Cycle
+    [Documentation]  Reboot BMC and wait for ready state.
+    Log  "Doing Reboot cycle"
+    Initiate BMC Reboot
+    Wait Until Keyword Succeeds  10 min  10 sec  Is BMC Ready
 
 
 Test Exit Logs