tree 750c3509eca6f124d0b83ebcf2baec73feef027c
parent 733df63ba8d7ff891de4cf8adc4e1fe301224908
author Tim Lee <timlee660101@gmail.com> 1623950651 +0800
committer George Keishing <gkeishin@in.ibm.com> 1624021211 +0000

redfish: managers: fix loop exit condition for verify maximum bmc dump

Symptom:
"Verify Maximum BMC Dump Creation" test item got failed.

Root cause:
According design of phosphor-debug-collector, the maximum dump allowed space for dump is 1024 (BMC_DUMP_TOTAL_SIZE)
There is another requirement, the minimum space required for one bmc dump is 20 (BMC_DUMP_MIN_SPACE_REQD)
However, the loop exit condition only consider the maximum in test item "Verify Maximum BMC Dump Creation".
Thus, the keyword "Create User Initiated BMC Dump" in the loop return fail then cause test got failed.

Solution:
Modify loop exit condition to consider minimum space requirement according dump manager design.

Tested:
robot -t Verify_Maximum_BMC_Dump_Creation redfish/managers/test_bmc_dumps.robot
Verify Maximum BMC Dump Creation :: Create maximum BMC dump and ve... | PASS |
1 test total, 1 passed, 0 failed

Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: I68306894033bfd5883f984679c1f8cfb4a443775