commit f5ce38c3a617e969f8aa6a79dac68623793b5972
author Michael Walsh <micwalsh@us.ibm.com> Thu Feb 27 12:46:20 2020 -0600
committer Michael Walsh <micwalsh@us.ibm.com> Thu Feb 27 12:46:35 2020 -0600
tree 9964c96a39cdad21b3cbf652eb1944673faa9da7
parent 5137ed57d4cfe5d7980e51a2dbdcd5c5312f28bb

Fix gv.set_exit_on_error(True)

Fix prior update to obmc_boot_test.py.

Calling gv.set_exit_on_error(True) affects subordinate users of gv
functions.

Change:

Call gv.set_exit_on_error(True) prior to local use of gv functions,
then call gv.set_exit_on_error(False).

Change-Id: I972f6a4e0761db9fd1e7ca3330cccd7cac23cc01
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

lib/obmc_boot_test.py

diff --git a/lib/obmc_boot_test.py b/lib/obmc_boot_test.py
index a62aea4..000a497 100755
--- a/lib/obmc_boot_test.py
+++ b/lib/obmc_boot_test.py
@@ -461,6 +461,12 @@
     gp.qprintn()
 
     global openbmc_model
+    if openbmc_model == "":
+        status, ret_values =\
+            grk.run_key_u("Get BMC System Model")
+        openbmc_model = ret_values
+        BuiltIn().set_global_variable("${openbmc_model}", openbmc_model)
+    gv.set_exit_on_error(True)
     gv.valid_value(openbmc_host)
     gv.valid_value(openbmc_username)
     gv.valid_value(openbmc_password)
@@ -471,39 +477,29 @@
     if os_host != "":
         gv.valid_value(os_username)
         gv.valid_value(os_password)
-
     if pdu_host != "":
         gv.valid_value(pdu_username)
         gv.valid_value(pdu_password)
         gv.valid_integer(pdu_slot_no)
     if openbmc_serial_host != "":
         gv.valid_integer(openbmc_serial_port)
-    if openbmc_model == "":
-        status, ret_values =\
-            grk.run_key_u("Get BMC System Model")
-        openbmc_model = ret_values
-        BuiltIn().set_global_variable("${openbmc_model}", openbmc_model)
     gv.valid_value(openbmc_model)
     gv.valid_integer(max_num_tests)
     gv.valid_integer(boot_pass)
     gv.valid_integer(boot_fail)
-
     plug_in_packages_list = grpi.rvalidate_plug_ins(plug_in_dir_paths)
     BuiltIn().set_global_variable("${plug_in_packages_list}",
                                   plug_in_packages_list)
-
     gv.valid_value(stack_mode, valid_values=['normal', 'skip'])
+    gv.set_exit_on_error(False)
     if len(boot_list) == 0 and len(boot_stack) == 0 and not ffdc_only:
         error_message = "You must provide either a value for either the" +\
             " boot_list or the boot_stack parm.\n"
         BuiltIn().fail(gp.sprint_error(error_message))
-
     valid_boot_list(boot_list, valid_boot_types)
     valid_boot_list(boot_stack, valid_boot_types)
-
     selected_PDU_boots = list(set(boot_list + boot_stack)
                               & set(boot_lists['PDU_reboot']))
-
     if len(selected_PDU_boots) > 0 and pdu_host == "":
         error_message = "You have selected the following boots which" +\
                         " require a PDU host but no value for pdu_host:\n"