Fix dump verify logic and enable in HW CI list
Change-Id: I70d674c099da3a7be72fa87db06a44054cf2b0c6
Signed-off-by: George Keishing <gkeishin@in.ibm.com>
diff --git a/redfish/test_xit.robot b/redfish/test_xit.robot
index af5086a..ccc1f92 100644
--- a/redfish/test_xit.robot
+++ b/redfish/test_xit.robot
@@ -21,23 +21,31 @@
[Tags] Verify_No_BMC_Dump_And_Application_Failures_In_BMC
# Check dump entry based on Redfish API availability.
+ Redfish.Login
${resp}= Redfish.Get /redfish/v1/Managers/bmc/LogServices/Dump/Entries
... valid_status_codes=[${HTTP_OK}, ${HTTP_NOT_FOUND}]
Log To Console ${resp}
- ${status}= Run Keyword If '${resp.status}' == '${HTTP_OK}'
+ Run Keyword If '${resp.status}' == '${HTTP_OK}'
... Should Be Equal As Strings ${resp.dict["Members@odata.count"]} 0
... msg=${resp.dict["Members@odata.count"]} dumps exist.
- ${rest_resp}= Run Keyword If '${status}' == 'None'
- ... Redfish.Get /xyz/openbmc_project/dump/bmc/entry/list
+ ${rest_resp}= Run Keyword If '${resp.status}' == '${HTTP_NOT_FOUND}'
+ ... Check For REST Dumps
+
+ Check For Regex In Journald ${ERROR_REGEX} error_check=${0} boot=-b
+
+
+*** Keywords ***
+
+Check For REST Dumps
+ [Documentation] Verify no BMC dump via REST path.
+
+ ${rest_resp}= Redfish.Get /xyz/openbmc_project/dump/bmc/entry/list
... valid_status_codes=[${HTTP_OK}, ${HTTP_NOT_FOUND}]
Log To Console ${rest_resp}
Should Be Equal As Strings ${rest_resp.status} ${HTTP_NOT_FOUND}
... msg=1 or more dumps exist.
-
- Check For Regex In Journald ${ERROR_REGEX} error_check=${0} boot=-b
-
diff --git a/test_lists/HW_CI b/test_lists/HW_CI
index 03b758f..0e4afea 100644
--- a/test_lists/HW_CI
+++ b/test_lists/HW_CI
@@ -25,4 +25,4 @@
#Local user tests.
-i Verify_AccountService_Available
#Check for BMC dump.
-#-i Verify_No_BMC_Dump_And_Application_Failures_In_BMC
+-i Verify_No_BMC_Dump_And_Application_Failures_In_BMC
diff --git a/test_lists/HW_CI_DEV b/test_lists/HW_CI_DEV
index 03b758f..0e4afea 100644
--- a/test_lists/HW_CI_DEV
+++ b/test_lists/HW_CI_DEV
@@ -25,4 +25,4 @@
#Local user tests.
-i Verify_AccountService_Available
#Check for BMC dump.
-#-i Verify_No_BMC_Dump_And_Application_Failures_In_BMC
+-i Verify_No_BMC_Dump_And_Application_Failures_In_BMC