Robotframework request package upgrade changes
Current working package version
robotframework-requests 0.7.2
To Test:
pip3 install robotframework-requests -U
or
# Once this commit is merged.
pip3 install -r requirements.txt
Version latest:
robotframework-requests 0.9.3
Refer Documentation:
https://marketsquare.github.io/robotframework-requests/doc/RequestsLibrary.html
What is not changed:
- The test cases under directory tests/ is not modified and is
deprecated but you can continue using it with older package
and configuration using
git clone -b v3.0-stable https://github.com/openbmc/openbmc-test-automation
Tested:
Upstream HW_CI test list, firmware code update and few other
test suite like ipmi, certificate, dumps, ffdc and redfish
test suites.
Note: I have not tested end to end, so it is likely there could be
grey areas where it could fail but should be minor w.r.t
response data format.
Resolves: openbmc/openbmc-test-automation#2105
Change-Id: Ie03b25ff88948bcccb09e9d82f8da86e28c92697
Signed-off-by: George Keishing <gkeishin@in.ibm.com>
diff --git a/lib/fan_utils.robot b/lib/fan_utils.robot
index d7b6a3c..9d2d615 100755
--- a/lib/fan_utils.robot
+++ b/lib/fan_utils.robot
@@ -110,8 +110,7 @@
${paths}= Get Endpoint Paths ${SENSORS_URI}fan_tach/ 0
FOR ${path} IN @{paths}
${response}= OpenBMC Get Request ${path}
- ${json}= To JSON ${response.content}
- ${target_speed}= Set Variable ${json["data"]["Target"]}
+ ${target_speed}= Set Variable ${response.json()["data"]["Target"]}
${max_target}= Run Keyword If ${target_speed} > ${max_target}
... Set Variable ${target_speed} ELSE Set Variable ${max_target}
END
@@ -132,15 +131,13 @@
# Get the fan target speed and the clockwise blade speed.
${path}= Catenate ${SENSORS_URI}fan_tach/${fan_name}_0
${response}= OpenBMC Get Request ${path}
- ${json}= To JSON ${response.content}
- ${fan_clockwise_speed}= Set Variable ${json["data"]["Value"]}
- ${target_speed}= Set Variable ${json["data"]["Target"]}
+ ${fan_clockwise_speed}= Set Variable ${response.json()["data"]["Value"]}
+ ${target_speed}= Set Variable ${response.json["data"]["Target"]}
# Get the counter-clockwise blade speed.
${path}= Catenate ${SENSORS_URI}fan_tach/${fan_name}_1
${response}= OpenBMC Get Request ${path}
- ${json}= To JSON ${response.content}
- ${fan_counterclockwise_speed}= Set Variable ${json["data"]["Value"]}
+ ${fan_counterclockwise_speed}= Set Variable ${response.json()["data"]["Value"]}
[Return] ${target_speed} ${fan_clockwise_speed}
... ${fan_counterclockwise_speed}